Changeset 259637 in webkit

Timestamp:

Apr 7, 2020 9:00:52 AM (4 years ago)

Author:

ddkilzer@apple.com

Message:

VisitedLinkStore.messages.in and VisitedLinkStore::addVisitedLinkHashFromPage() don't agree on type of linkHash
<​https://webkit.org/b/210094>
<rdar://problem/60334644>

Reviewed by Chris Dumez.

• Scripts/webkit/messages.py:

(types_that_cannot_be_forward_declared):

• Don't forward-declare WebCore::SharedStringHash as a class since it is a uint32_t.
• UIProcess/VisitedLinkStore.messages.in:
• Use WebCore::SharedStringHash type for linkHash to fix the type mismatch.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkit/messages.py (modified) (1 diff)
• UIProcess/VisitedLinkStore.messages.in (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-04-07  David Kilzer  <ddkilzer@apple.com>
+
+        VisitedLinkStore.messages.in and VisitedLinkStore::addVisitedLinkHashFromPage() don't agree on type of `linkHash`
+        <https://webkit.org/b/210094>
+        <rdar://problem/60334644>
+
+        Reviewed by Chris Dumez.
+
+        * Scripts/webkit/messages.py:
+        (types_that_cannot_be_forward_declared):
+        - Don't forward-declare WebCore::SharedStringHash as a class
+          since it is a uint32_t.
+        * UIProcess/VisitedLinkStore.messages.in:
+        - Use WebCore::SharedStringHash type for `linkHash` to fix the
+          type mismatch.
+
 2020-04-07  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/Scripts/webkit/messages.py

@@ -223 +223 @@
         'WebCore::ServiceWorkerOrClientIdentifier',
         'WebCore::ServiceWorkerRegistrationIdentifier',
+        'WebCore::SharedStringHash',
         'WebCore::SleepDisablerIdentifier',
         'WebCore::SWServerConnectionIdentifier',

trunk/Source/WebKit/UIProcess/VisitedLinkStore.messages.in

@@ -22 +22 @@
 
 messages -> VisitedLinkStore {
-    AddVisitedLinkHashFromPage(WebKit::WebPageProxyIdentifier pageProxyID, uint64_t linkHash)
+    AddVisitedLinkHashFromPage(WebKit::WebPageProxyIdentifier pageProxyID, WebCore::SharedStringHash linkHash)
 }