Changeset 259658 in webkit


Ignore:
Timestamp:
Apr 7, 2020 12:35:54 PM (4 years ago)
Author:
Ross Kirsling
Message:

Update JSTests to assume ICU 60+
https://bugs.webkit.org/show_bug.cgi?id=210085

Reviewed by Yusuke Suzuki.

  • stress/intl-collator.js:
  • stress/intl-constructors-with-proxy.js:
  • stress/intl-datetimeformat.js:
  • stress/intl-default-locale.js:
  • stress/intl-numberformat-format-to-parts.js:
  • stress/intl-numberformat.js: Ensure a test case doesn't depend on behavior changed in ICU 64.
  • stress/intl-object.js:
  • stress/intl-pluralrules.js: Correct two invalid test cases.
  • test262/config.yaml:

Remove skips.

Location:
trunk/JSTests
Files:
10 edited

Legend:

Unmodified
Added
Removed
  • trunk/JSTests/ChangeLog

    r259646 r259658  
     12020-04-07  Ross Kirsling  <ross.kirsling@sony.com>
     2
     3        Update JSTests to assume ICU 60+
     4        https://bugs.webkit.org/show_bug.cgi?id=210085
     5
     6        Reviewed by Yusuke Suzuki.
     7
     8        * stress/intl-collator.js:
     9        * stress/intl-constructors-with-proxy.js:
     10        * stress/intl-datetimeformat.js:
     11        * stress/intl-default-locale.js:
     12        * stress/intl-numberformat-format-to-parts.js:
     13        * stress/intl-numberformat.js: Ensure a test case doesn't depend on behavior changed in ICU 64.
     14        * stress/intl-object.js:
     15        * stress/intl-pluralrules.js: Correct two invalid test cases.
     16        * test262/config.yaml:
     17        Remove skips.
     18
    1192020-04-07  Yusuke Suzuki  <ysuzuki@apple.com>
    220
  • trunk/JSTests/stress/intl-collator.js

    r259480 r259658  
    1 //@ skip if $hostOS == "windows"
    2 
    31function shouldBe(actual, expected) {
    42    if (actual !== expected)
  • trunk/JSTests/stress/intl-constructors-with-proxy.js

    r202567 r259658  
    1 //@ skip if $hostOS == "windows"
    2 
    31function shouldBe(actual, expected) {
    42    if (actual !== expected)
  • trunk/JSTests/stress/intl-datetimeformat.js

    r259480 r259658  
    1 //@ skip if $hostOS == "windows"
    2 
    31function shouldBe(actual, expected) {
    42    if (actual !== expected)
  • trunk/JSTests/stress/intl-default-locale.js

    r259480 r259658  
    1 //@ skip if $hostOS == "windows"
    2 
    31function shouldBe(actual, expected) {
    42    if (actual !== expected)
  • trunk/JSTests/stress/intl-numberformat-format-to-parts.js

    r259480 r259658  
    1 //@ skip if $hostOS == "windows" or $hostOS == "darwin"
    2 
    31function shouldBe(actual, expected) {
    42    if (actual !== expected)
  • trunk/JSTests/stress/intl-numberformat.js

    r259480 r259658  
    1 //@ skip if $hostOS == "windows" or $hostOS == "darwin" or $hostOS == "linux"
    2 
    31function shouldBe(actual, expected) {
    42    if (actual !== expected)
     
    342340
    343341// Test locales.
    344 shouldBe(Intl.NumberFormat('en').format(1234.567), '1,234.567');
    345 shouldBe(Intl.NumberFormat('es').format(1234.567), '1234,567');
    346 shouldBe(Intl.NumberFormat('de').format(1234.567), '1.234,567');
     342shouldBe(Intl.NumberFormat('en').format(12345.678), '12,345.678');
     343shouldBe(Intl.NumberFormat('es').format(12345.678), '12.345,678');
     344shouldBe(Intl.NumberFormat('de').format(12345.678), '12.345,678');
    347345
    348346// Test numbering systems.
  • trunk/JSTests/stress/intl-object.js

    r259480 r259658  
    1 //@ skip if $hostOS == "windows"
    2 
    31function shouldBe(actual, expected) {
    42    if (actual !== expected)
  • trunk/JSTests/stress/intl-pluralrules.js

    r259480 r259658  
    1 //@ skip if $hostOS == "windows"
    2 
    31function shouldBe(actual, expected) {
    42    if (actual !== expected)
     
    285283shouldBe(new Intl.PluralRules('en', {type: 'ordinal', maximumSignificantDigits: 3}).select(123.4), 'few');
    286284
    287 // These require ICU v59+
    288 /*
    289285shouldBe(new Intl.PluralRules('en', {minimumFractionDigits: 1}).select(1), 'other');
    290286shouldBe(new Intl.PluralRules('en', {minimumSignificantDigits: 2}).select(1), 'other');
     
    292288// Plural categories are correctly determined
    293289shouldBe(new Intl.PluralRules('en').resolvedOptions().pluralCategories instanceof Array, true);
    294 shouldBe(new Intl.PluralRules('ar').resolvedOptions().pluralCategories.join(), 'zero,one,two,few,many,other');
     290shouldBe(new Intl.PluralRules('ar').resolvedOptions().pluralCategories.join(), 'few,many,one,two,zero,other');
    295291shouldBe(new Intl.PluralRules('en').resolvedOptions().pluralCategories.join(), 'one,other');
    296 shouldBe(new Intl.PluralRules('en', {type: 'ordinal'}).resolvedOptions().pluralCategories.join(), 'one,two,few,other');
    297 */
     292shouldBe(new Intl.PluralRules('en', {type: 'ordinal'}).resolvedOptions().pluralCategories.join(), 'few,one,two,other');
  • trunk/JSTests/test262/config.yaml

    r259529 r259658  
    3838    - Intl.Segmenter
    3939  paths:
    40     # https://bugs.webkit.org/show_bug.cgi?id=192920
    41     - test/intl402/NumberFormat/prototype/formatToParts
    42 
    4340    - test/built-ins/DataView/prototype/getBigInt64
    4441    - test/built-ins/DataView/prototype/getBigUint64
     
    118115    - test/built-ins/Reflect/ownKeys/return-on-corresponding-order-large-index.js
    119116
    120     # https://bugs.webkit.org/show_bug.cgi?id=192920
    121     - test/intl402/PluralRules/prototype/resolvedOptions/order.js
    122     - test/intl402/PluralRules/prototype/resolvedOptions/pluralCategories.js
    123117
    124118    # https://bugs.webkit.org/show_bug.cgi?id=190800
Note: See TracChangeset for help on using the changeset viewer.