Changeset 259699 in webkit

Timestamp:

Apr 7, 2020 6:38:41 PM (4 years ago)

Author:

aakash_jain@apple.com

Message:

[ews] Add unit tests for layout tests factories
​https://bugs.webkit.org/show_bug.cgi?id=210150

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/factories_unittest.py:

(TestLayoutTestsFactory):
(TestLayoutTestsFactory.test_macos_wk1_release_factory): Added unit-test.
(TestLayoutTestsFactory.test_macos_wk1_debug_factory): Ditto.
(TestLayoutTestsFactory.test_macos_wk2_factory): Ditto.
(TestLayoutTestsFactory.test_ios_wk2_factory): Ditto.
(TestGTKFactory): Renamed.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/factories_unittest.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/factories_unittest.py

@@ -204 +204 @@
 
 
-class TestGTKFactory(TestCase):
+class TestLayoutTestsFactory(TestCase):
+    def test_macos_wk1_release_factory(self):
+        factory = factories.macOSWK1Factory(platform='mac-mojave', configuration='release', architectures=["x86_64"])
+        self.assertBuildSteps(factory.steps, [
+            _BuildStepFactory(steps.ConfigureBuild, platform='mac-mojave', configuration='release', architectures=["x86_64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
+            _BuildStepFactory(steps.ValidatePatch),
+            _BuildStepFactory(steps.PrintConfiguration),
+            _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ApplyPatch),
+            _BuildStepFactory(steps.DownloadBuiltProduct),
+            _BuildStepFactory(steps.ExtractBuiltProduct),
+            _BuildStepFactory(steps.KillOldProcesses),
+            _BuildStepFactory(steps.RunWebKit1Tests),
+            _BuildStepFactory(steps.SetBuildSummary),
+        ])
+
+    def test_macos_wk1_debug_factory(self):
+        factory = factories.macOSWK1Factory(platform='mac-mojave', configuration='debug', architectures=["x86_64"])
+        self.assertBuildSteps(factory.steps, [
+            _BuildStepFactory(steps.ConfigureBuild, platform='mac-mojave', configuration='debug', architectures=["x86_64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
+            _BuildStepFactory(steps.ValidatePatch),
+            _BuildStepFactory(steps.PrintConfiguration),
+            _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ApplyPatch),
+            _BuildStepFactory(steps.DownloadBuiltProduct),
+            _BuildStepFactory(steps.ExtractBuiltProduct),
+            _BuildStepFactory(steps.KillOldProcesses),
+            _BuildStepFactory(steps.RunWebKit1Tests),
+            _BuildStepFactory(steps.SetBuildSummary),
+        ])
+
+    def test_macos_wk2_factory(self):
+        factory = factories.macOSWK2Factory(platform='mac-mojave', configuration='release', architectures=["x86_64"])
+        self.assertBuildSteps(factory.steps, [
+            _BuildStepFactory(steps.ConfigureBuild, platform='mac-mojave', configuration='release', architectures=["x86_64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
+            _BuildStepFactory(steps.ValidatePatch),
+            _BuildStepFactory(steps.PrintConfiguration),
+            _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ApplyPatch),
+            _BuildStepFactory(steps.DownloadBuiltProduct),
+            _BuildStepFactory(steps.ExtractBuiltProduct),
+            _BuildStepFactory(steps.KillOldProcesses),
+            _BuildStepFactory(steps.RunWebKitTests),
+            _BuildStepFactory(steps.SetBuildSummary),
+        ])
+
+    def test_ios_wk2_factory(self):
+        factory = factories.iOSTestsFactory(platform='ios-simulator-13', configuration='release', architectures=["x86_64"])
+        self.assertBuildSteps(factory.steps, [
+            _BuildStepFactory(steps.ConfigureBuild, platform='ios-simulator-13', configuration='release', architectures=["x86_64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
+            _BuildStepFactory(steps.ValidatePatch),
+            _BuildStepFactory(steps.PrintConfiguration),
+            _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ApplyPatch),
+            _BuildStepFactory(steps.DownloadBuiltProduct),
+            _BuildStepFactory(steps.ExtractBuiltProduct),
+            _BuildStepFactory(steps.KillOldProcesses),
+            _BuildStepFactory(steps.RunWebKitTests),
+            _BuildStepFactory(steps.SetBuildSummary),
+        ])
+
     def test_gtk_factory(self):
         factory = factories.GTKTestsFactory(platform='gtk', configuration='release', architectures=["x86_64"])

trunk/Tools/ChangeLog

@@ +1 @@
+2020-04-07  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews] Add unit tests for layout tests factories
+        https://bugs.webkit.org/show_bug.cgi?id=210150
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/factories_unittest.py:
+        (TestLayoutTestsFactory):
+        (TestLayoutTestsFactory.test_macos_wk1_release_factory): Added unit-test.
+        (TestLayoutTestsFactory.test_macos_wk1_debug_factory): Ditto.
+        (TestLayoutTestsFactory.test_macos_wk2_factory): Ditto.
+        (TestLayoutTestsFactory.test_ios_wk2_factory): Ditto.
+        (TestGTKFactory): Renamed.
+
 2020-04-07  Aakash Jain  <aakash_jain@apple.com>