Changeset 260348 in webkit

Timestamp:

Apr 19, 2020 8:46:40 PM (4 years ago)

Author:

ddkilzer@apple.com

Message:

REGRESSION (r244091): Leak of TaskStateChangedCallbackType due to missing -dealloc
<​https://webkit.org/b/210710>
<rdar://problem/61992856>

Reviewed by Darin Adler.

• Shared/Cocoa/ProcessTaskStateObserver.mm:

(-[WKProcessTaskStateObserverDelegate dealloc]): Add.

• Release _taskStateChangedCallback to fix the leak.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/Cocoa/ProcessTaskStateObserver.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-04-19  David Kilzer  <ddkilzer@apple.com>
+
+        REGRESSION (r244091): Leak of TaskStateChangedCallbackType due to missing -dealloc
+        <https://webkit.org/b/210710>
+        <rdar://problem/61992856>
+
+        Reviewed by Darin Adler.
+
+        * Shared/Cocoa/ProcessTaskStateObserver.mm:
+        (-[WKProcessTaskStateObserverDelegate dealloc]): Add.
+        - Release _taskStateChangedCallback to fix the leak.
+
 2020-04-19  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/WebKit/Shared/Cocoa/ProcessTaskStateObserver.mm

@@ -44 +44 @@
 
 @implementation WKProcessTaskStateObserverDelegate
+- (void)dealloc
+{
+    [_taskStateChangedCallback release];
+    [super dealloc];
+}
+
 - (void)process:(BKSProcess *)process taskStateDidChange:(BKSProcessTaskState)newState
 {