Changeset 260360 in webkit

Timestamp:

Apr 20, 2020 4:56:55 AM (4 years ago)

Author:

graouts@webkit.org

Message:

WebAnimations API doesn't properly apply keyframe easings to transforms
​https://bugs.webkit.org/show_bug.cgi?id=210526
<rdar://problem/61800424>

Reviewed by Antti Koivisto.

Source/WebCore:

GraphicsLayerCA has code that determines whether an animation can be accelerated looking at the timing function of its keyframes and excluding
animations that use a steps timing function as one of its values. However, we we would fail to set the timing function on the KeyframeValue for
each keyframe in the KeyframeList we create for a JS-originated animation. We now do this correctly.

Test: webanimations/transform-animation-with-steps-timing-function-not-accelerated.html

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::updateBlendingKeyframes):

LayoutTests:

Add a new test that checks that an animation targeting an accelerted property does not yield an accelerated animation if one of its keyframes contains a steps timing function.

• webanimations/transform-animation-with-steps-timing-function-not-accelerated-expected.txt: Added.
• webanimations/transform-animation-with-steps-timing-function-not-accelerated.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webanimations/transform-animation-with-steps-timing-function-not-accelerated-expected.txt (added)
• LayoutTests/webanimations/transform-animation-with-steps-timing-function-not-accelerated.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/animation/KeyframeEffect.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-04-20  Antoine Quint  <graouts@apple.com>
+
+        WebAnimations API doesn't properly apply keyframe easings to transforms
+        https://bugs.webkit.org/show_bug.cgi?id=210526
+        <rdar://problem/61800424>
+
+        Reviewed by Antti Koivisto.
+
+        Add a new test that checks that an animation targeting an accelerted property does not yield an accelerated animation if one of its keyframes contains a steps timing function.
+
+        * webanimations/transform-animation-with-steps-timing-function-not-accelerated-expected.txt: Added.
+        * webanimations/transform-animation-with-steps-timing-function-not-accelerated.html: Added.
+
 2020-04-20  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-04-20  Antoine Quint  <graouts@apple.com>
+
+        WebAnimations API doesn't properly apply keyframe easings to transforms
+        https://bugs.webkit.org/show_bug.cgi?id=210526
+        <rdar://problem/61800424>
+
+        Reviewed by Antti Koivisto.
+
+        GraphicsLayerCA has code that determines whether an animation can be accelerated looking at the timing function of its keyframes and excluding
+        animations that use a steps timing function as one of its values. However, we we would fail to set the timing function on the KeyframeValue for
+        each keyframe in the KeyframeList we create for a JS-originated animation. We now do this correctly.
+
+        Test: webanimations/transform-animation-with-steps-timing-function-not-accelerated.html
+
+        * animation/KeyframeEffect.cpp:
+        (WebCore::KeyframeEffect::updateBlendingKeyframes):
+
 2020-04-20  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/WebCore/animation/KeyframeEffect.cpp

@@ -771 +771 @@
     for (auto& keyframe : m_parsedKeyframes) {
         KeyframeValue keyframeValue(keyframe.computedOffset, nullptr);
+        keyframeValue.setTimingFunction(keyframe.timingFunction->clone());
 
         auto styleProperties = keyframe.style->immutableCopyIfNeeded();