Changeset 260435 in webkit

Timestamp:

Apr 21, 2020 10:14:08 AM (4 years ago)

Author:

Chris Dumez

Message:

REGRESSION (r256808): “A problem repeatedly occurred” when attempting to load ​https://bungalow.com/listings/bay-area
​https://bugs.webkit.org/show_bug.cgi?id=210801
<rdar://problem/61658940>

Reviewed by Antti Koivisto.

Even though the page uses the 'async' attribute on the mapbox-gl.js script, deferring the execution of this
script gets the page into a bad state, causing it to use a lot of CPU & memory until the process crashes.
Since we don't have any other evidence of breakage from r256808 yet and since r256808 was a massive PLT
progression, I am opting to add a quirk to disable the async script optimization on bungalow.com for now.

• dom/Document.cpp:

(WebCore::Document::shouldDeferAsynchronousScriptsUntilParsingFinishes const):

• page/Quirks.cpp:

(WebCore::Quirks::shouldBypassAsyncScriptDeferring const):

• page/Quirks.h:
• platform/RegistrableDomain.h:

(WebCore::RegistrableDomain::operator== const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (1 diff)
• page/Quirks.cpp (modified) (1 diff)
• page/Quirks.h (modified) (2 diffs)
• platform/RegistrableDomain.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-04-21  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION (r256808): “A problem repeatedly occurred” when attempting to load https://bungalow.com/listings/bay-area
+        https://bugs.webkit.org/show_bug.cgi?id=210801
+        <rdar://problem/61658940>
+
+        Reviewed by Antti Koivisto.
+
+        Even though the page uses the 'async' attribute on the mapbox-gl.js script, deferring the execution of this
+        script gets the page into a bad state, causing it to use a lot of CPU & memory until the process crashes.
+        Since we don't have any other evidence of breakage from r256808 yet and since r256808 was a massive PLT
+        progression, I am opting to add a quirk to disable the async script optimization on bungalow.com for now.
+
+        * dom/Document.cpp:
+        (WebCore::Document::shouldDeferAsynchronousScriptsUntilParsingFinishes const):
+        * page/Quirks.cpp:
+        (WebCore::Quirks::shouldBypassAsyncScriptDeferring const):
+        * page/Quirks.h:
+        * platform/RegistrableDomain.h:
+        (WebCore::RegistrableDomain::operator== const):
+
 2020-04-16  Sergio Villar Senin  <svillar@igalia.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -5558 +5558 @@
         return false;
 
+    if (quirks().shouldBypassAsyncScriptDeferring())
+        return false;
+
     return parsing() && !(view() && view()->hasEverPainted());
 }

trunk/Source/WebCore/page/Quirks.cpp

@@ -679 +679 @@
 }
 
+bool Quirks::shouldBypassAsyncScriptDeferring() const
+{
+    if (!needsQuirks())
+        return false;
+
+    if (!m_shouldBypassAsyncScriptDeferring) {
+        auto domain = RegistrableDomain { m_document->topDocument().url() };
+        // Deferring 'mapbox-gl.js' script on bungalow.com causes the script to get in a bad state (rdar://problem/61658940).
+        m_shouldBypassAsyncScriptDeferring = (domain == "bungalow.com");
+    }
+    return *m_shouldBypassAsyncScriptDeferring;
+}
+
 bool Quirks::shouldMakeEventListenerPassive(const EventTarget& eventTarget, const AtomString& eventType, const EventListener& eventListener)
 {

trunk/Source/WebCore/page/Quirks.h

@@ -89 +89 @@
 
     bool shouldBypassBackForwardCache() const;
+    bool shouldBypassAsyncScriptDeferring() const;
 
     static bool shouldMakeEventListenerPassive(const EventTarget&, const AtomString& eventType, const EventListener&);
@@ -122 +123 @@
 #endif
     mutable Optional<bool> m_needsCanPlayAfterSeekedQuirk;
+    mutable Optional<bool> m_shouldBypassAsyncScriptDeferring;
 };
 

trunk/Source/WebCore/platform/RegistrableDomain.h

@@ -55 +55 @@
     bool operator!=(const RegistrableDomain& other) const { return m_registrableDomain != other.m_registrableDomain; }
     bool operator==(const RegistrableDomain& other) const { return m_registrableDomain == other.m_registrableDomain; }
+    bool operator==(const char* other) const { return m_registrableDomain == other; }
 
     bool matches(const URL& url) const