Changeset 260452 in webkit
- Timestamp:
- Apr 21, 2020 1:52:54 PM (4 years ago)
- Location:
- trunk/Tools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r260451 r260452 1 2020-04-21 Darin Adler <darin@apple.com> 2 3 WTF API test for StringConcatenate failing for internal Apple builds 4 https://bugs.webkit.org/show_bug.cgi?id=210812 5 6 Reviewed by Brent Fulgham. 7 8 * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: 9 (TestWebKitAPI::TEST): Add back a case for when UChar is uint16_t. 10 1 11 2020-04-21 Kate Cheney <katherine_cheney@apple.com> 2 12 -
trunk/Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp
r259606 r260452 84 84 85 85 EXPECT_STREQ("hello 42 world", makeString("hello ", static_cast<unsigned char>(42) , " world").utf8().data()); 86 EXPECT_STREQ("hello 42 world", makeString("hello ", static_cast<unsigned short>(42) , " world").utf8().data()); 86 // FIXME: Remove this if statement once we have UChar as char16_t in all configurations. 87 if constexpr (std::is_same_v<UChar, uint16_t>) 88 EXPECT_STREQ("hello * world", makeString("hello ", static_cast<unsigned short>(42) , " world").utf8().data()); 89 else 90 EXPECT_STREQ("hello 42 world", makeString("hello ", static_cast<unsigned short>(42) , " world").utf8().data()); 87 91 EXPECT_STREQ("hello 4 world", makeString("hello ", sizeof(int) , " world").utf8().data()); // size_t 88 92 EXPECT_STREQ("hello 4 world", makeString("hello ", offsetof(S, i) , " world").utf8().data()); // size_t
Note: See TracChangeset
for help on using the changeset viewer.