Changeset 260642 in webkit

Timestamp:

Apr 24, 2020 7:57:32 AM (4 years ago)

Author:

Chris Dumez

Message:

[iOS] Stop using legacy BKSApplicationStateMonitor
​https://bugs.webkit.org/show_bug.cgi?id=210945

Reviewed by Tim Horton.

Source/WebKit:

Stop using legacy BKSApplicationStateMonitor and use RunningBoard API instead.

• Configurations/WebKit.xcconfig:

Stop linking against ApplicationServices when using iOS 14 SDK now that we are
fully transitioned to RunningBoard.

• Platform/spi/ios/RunningBoardServicesSPI.h:
• UIProcess/ApplicationStateTracker.h:
• UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::ApplicationStateTracker):
(WebKit::isApplicationForeground):
(WebKit::ApplicationStateTracker::~ApplicationStateTracker):
(WebKit::isBackgroundState): Deleted.

• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::isApplicationVisible):

WebKitLibraries:

• WebKitPrivateFrameworkStubs/iOS/13/RunningBoardServices.framework/RunningBoardServices.tbd:

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/Configurations/WebKit.xcconfig (modified) (1 diff)
• Source/WebKit/Platform/spi/ios/RunningBoardServicesSPI.h (modified) (2 diffs)
• Source/WebKit/UIProcess/ApplicationStateTracker.h (modified) (2 diffs)
• Source/WebKit/UIProcess/ApplicationStateTracker.mm (modified) (4 diffs)
• Source/WebKit/UIProcess/ios/PageClientImplIOS.mm (modified) (2 diffs)
• WebKitLibraries/ChangeLog (modified) (1 diff)
• WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/13/RunningBoardServices.framework/RunningBoardServices.tbd (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-04-24  Chris Dumez  <cdumez@apple.com>
+
+        [iOS] Stop using legacy BKSApplicationStateMonitor
+        https://bugs.webkit.org/show_bug.cgi?id=210945
+
+        Reviewed by Tim Horton.
+
+        Stop using legacy BKSApplicationStateMonitor and use RunningBoard API instead.
+
+        * Configurations/WebKit.xcconfig:
+        Stop linking against ApplicationServices when using iOS 14 SDK now that we are
+        fully transitioned to RunningBoard.
+
+        * Platform/spi/ios/RunningBoardServicesSPI.h:
+        * UIProcess/ApplicationStateTracker.h:
+        * UIProcess/ApplicationStateTracker.mm:
+        (WebKit::ApplicationStateTracker::ApplicationStateTracker):
+        (WebKit::isApplicationForeground):
+        (WebKit::ApplicationStateTracker::~ApplicationStateTracker):
+        (WebKit::isBackgroundState): Deleted.
+        * UIProcess/ios/PageClientImplIOS.mm:
+        (WebKit::PageClientImpl::isApplicationVisible):
+
 2020-04-23  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebKit/Configurations/WebKit.xcconfig

@@ -49 +49 @@
 WK_APPKIT_LDFLAGS_maccatalyst = -framework AppKit;
 
-WK_ASSERTION_SERVICES_LDFLAGS = $(WK_ASSERTION_SERVICES_LDFLAGS_$(WK_COCOA_TOUCH));
-WK_ASSERTION_SERVICES_LDFLAGS_cocoatouch = -framework AssertionServices;
+WK_ASSERTION_SERVICES_LDFLAGS = $(WK_ASSERTION_SERVICES_LDFLAGS_$(WK_PLATFORM_NAME));
+WK_ASSERTION_SERVICES_LDFLAGS_iphoneos = $(WK_ASSERTION_SERVICES_LDFLAGS$(WK_IOS_14));
+WK_ASSERTION_SERVICES_LDFLAGS_iphonesimulator = $(WK_ASSERTION_SERVICES_LDFLAGS$(WK_IOS_14));
+WK_ASSERTION_SERVICES_LDFLAGS_IOS_BEFORE_14 = -framework AssertionServices;
+// FIXME: It is unnecessary to link against AssertionServices with the latest SDK for the following platforms too.
+WK_ASSERTION_SERVICES_LDFLAGS_watchos = -framework AssertionServices;
+WK_ASSERTION_SERVICES_LDFLAGS_watchsimulator = -framework AssertionServices;
+WK_ASSERTION_SERVICES_LDFLAGS_appletvos = -framework AssertionServices;
+WK_ASSERTION_SERVICES_LDFLAGS_appletvsimulator = -framework AssertionServices;
+WK_ASSERTION_SERVICES_LDFLAGS_maccatalyst = -framework AssertionServices;
 
 WK_RUNNINGBOARD_SERVICES_LDFLAGS = $(WK_RUNNINGBOARD_SERVICES_LDFLAGS_$(WK_COCOA_TOUCH));

trunk/Source/WebKit/Platform/spi/ios/RunningBoardServicesSPI.h

@@ -43 +43 @@
 @end
 
-@protocol RBSAssertionObserving <NSObject>
-- (void)assertionWillInvalidate:(RBSAssertion *)assertion;
-- (void)assertion:(RBSAssertion *)assertion didInvalidateWithError:(NSError *)error;
-@end
+@protocol RBSAssertionObserving;
 
 @interface RBSAssertion : NSObject
@@ -56 +53 @@
 @end
 
+@protocol RBSAssertionObserving <NSObject>
+- (void)assertionWillInvalidate:(RBSAssertion *)assertion;
+- (void)assertion:(RBSAssertion *)assertion didInvalidateWithError:(NSError *)error;
+@end
+
+@interface RBSProcessIdentifier : NSObject
++ (RBSProcessIdentifier *)identifierWithPid:(pid_t)pid;
+@end
+
+typedef NS_ENUM(uint8_t, RBSTaskState) {
+    RBSTaskStateUnknown                 = 0,
+    RBSTaskStateNone                    = 1,
+    RBSTaskStateRunningUnknown          = 2,
+    RBSTaskStateRunningSuspended        = 3,
+    RBSTaskStateRunningScheduled        = 4,
+};
+
+@interface RBSProcessState : NSObject
+@property (nonatomic, readonly, assign) RBSTaskState taskState;
+@property (nonatomic, readonly, copy) NSSet<NSString *> *endowmentNamespaces;
+@end
+
+@interface RBSProcessHandle : NSObject
++ (RBSProcessHandle *)handleForIdentifier:(RBSProcessIdentifier *)identifier error:(NSError **)outError;
+@property (nonatomic, readonly, strong) RBSProcessState *currentState;
+@end
+
 #endif

trunk/Source/WebKit/UIProcess/ApplicationStateTracker.h

@@ -63 +63 @@
     bool m_isInBackground;
 
-    RetainPtr<BKSApplicationStateMonitor> m_applicationStateMonitor;
-
     id m_didEnterBackgroundObserver;
     id m_didFinishSnapshottingAfterEnteringBackgroundObserver;
@@ -81 +79 @@
 
 ApplicationType applicationType(UIWindow *);
+bool isApplicationForeground(pid_t);
 
 }

trunk/Source/WebKit/UIProcess/ApplicationStateTracker.mm

@@ -31 +31 @@
 #import "AssertionServicesSPI.h"
 #import "Logging.h"
+#import "RunningBoardServicesSPI.h"
 #import "SandboxUtilities.h"
 #import "UIKitSPI.h"
@@ -62 +63 @@
 
     return ApplicationType::Application;
-}
-
-static bool isBackgroundState(BKSApplicationState state)
-{
-    switch (state) {
-    case BKSApplicationStateBackgroundRunning:
-    case BKSApplicationStateBackgroundTaskSuspended:
-        return true;
-
-    default:
-        return false;
-    }
 }
 
@@ -169 +158 @@
         ASSERT(applicationPID);
 
-        auto applicationStateMonitor = adoptNS([[BKSApplicationStateMonitor alloc] init]);
-        m_isInBackground = isBackgroundState([applicationStateMonitor mostElevatedApplicationStateForPID:applicationPID]);
-        [applicationStateMonitor invalidate];
+        m_isInBackground = !isApplicationForeground(applicationPID);
 
         // Workaround for <rdar://problem/34028921>. If the host application is StoreKitUIService then it is also a ViewService
@@ -195 +182 @@
 }
 
+bool isApplicationForeground(pid_t pid)
+{
+    RBSProcessIdentifier *processIdentifier = [RBSProcessIdentifier identifierWithPid:pid];
+    if (!processIdentifier) {
+        RELEASE_LOG_ERROR(ProcessSuspension, "isApplicationForeground: Failed to construct RBSProcessIdentifier from PID %d", pid);
+        return false;
+    }
+
+    NSError *error = nil;
+    RBSProcessHandle *processHandle = [RBSProcessHandle handleForIdentifier:processIdentifier error:&error];
+    if (!processHandle) {
+        RELEASE_LOG_ERROR(ProcessSuspension, "isApplicationForeground: Failed to get RBSProcessHandle for process with PID %d, error: %{public}@", pid, error);
+        return false;
+    }
+
+    RBSProcessState *state = processHandle.currentState;
+    if (state.taskState != RBSTaskStateRunningScheduled) {
+        RELEASE_LOG_ERROR(ProcessSuspension, "isApplicationForeground: Process with PID %d is not running", pid);
+        return false;
+    }
+
+    return [[state endowmentNamespaces] containsObject:@"com.apple.frontboard.visibility"];
+}
+
 ApplicationStateTracker::~ApplicationStateTracker()
 {
     RELEASE_LOG(ViewState, "%p - ~ApplicationStateTracker", this);
-    if (m_applicationStateMonitor) {
-        [m_applicationStateMonitor invalidate];
-        return;
-    }
 
     NSNotificationCenter *notificationCenter = [NSNotificationCenter defaultCenter];

trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm

@@ -39 +39 @@
 #import "NativeWebKeyboardEvent.h"
 #import "NavigationState.h"
+#import "RunningBoardServicesSPI.h"
 #import "StringUtilities.h"
 #import "UIKitSPI.h"
@@ -169 +170 @@
     ASSERT(applicationPID);
 
-    auto applicationStateMonitor = adoptNS([[BKSApplicationStateMonitor alloc] init]);
-    auto applicationState = [applicationStateMonitor mostElevatedApplicationStateForPID:applicationPID];
-    [applicationStateMonitor invalidate];
-    return applicationState != BKSApplicationStateBackgroundRunning && applicationState != BKSApplicationStateBackgroundTaskSuspended;
+    return isApplicationForeground(applicationPID);
 }
 

trunk/WebKitLibraries/ChangeLog

@@ +1 @@
+2020-04-24  Chris Dumez  <cdumez@apple.com>
+
+        [iOS] Stop using legacy BKSApplicationStateMonitor
+        https://bugs.webkit.org/show_bug.cgi?id=210945
+
+        Reviewed by Tim Horton.
+
+        * WebKitPrivateFrameworkStubs/iOS/13/RunningBoardServices.framework/RunningBoardServices.tbd:
+
 2020-03-16  Keith Rollin  <krollin@apple.com>
 

trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/13/RunningBoardServices.framework/RunningBoardServices.tbd

@@ -6 +6 @@
 exports:
   - archs:           [ x86_64, arm64, arm64e ]
-    objc-classes:    [ RBSAttribute, RBSDomainAttribute, RBSTarget, RBSAssertion ]
+    objc-classes:    [ RBSAttribute, RBSDomainAttribute, RBSTarget, RBSAssertion, RBSProcessIdentifier, RBSProcessState, RBSProcessHandle ]
 ...