Changeset 260674 in webkit


Ignore:
Timestamp:
Apr 24, 2020 2:53:50 PM (4 years ago)
Author:
ysuzuki@apple.com
Message:

[JSC] Fix DataFormatJSBigInt32 missing part
​https://bugs.webkit.org/show_bug.cgi?id=210986

Reviewed by Mark Lam.

Add missing part of DataFormatJSBigInt32 implementation.

  • bytecode/DataFormat.h:

(JSC::dataFormatToString):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):

Location:
trunk/Source/JavaScriptCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r260664 r260674  
     12020-04-24  Yusuke Suzuki  <ysuzuki@apple.com>
     2
     3        [JSC] Fix DataFormatJSBigInt32 missing part
     4        https://bugs.webkit.org/show_bug.cgi?id=210986
     5
     6        Reviewed by Mark Lam.
     7
     8        Add missing part of DataFormatJSBigInt32 implementation.
     9
     10        * bytecode/DataFormat.h:
     11        (JSC::dataFormatToString):
     12        * dfg/DFGSpeculativeJIT.cpp:
     13        (JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):
     14
    1152020-04-24  Yusuke Suzuki  <ysuzuki@apple.com>
    216

  • trunk/Source/JavaScriptCore/bytecode/DataFormat.h

    r260331 r260674  
    4545    DataFormatCell = 6,
    4646    DataFormatStorage = 7,
    47     DataFormatBigInt32 = 8, // FIXME: currently unused
     47    DataFormatBigInt32 = 8, // FIXME: https://bugs.webkit.org/show_bug.cgi?id=210957 Actually support BigInt32 DataFormat.
    4848    DataFormatJS = 16,
    4949    DataFormatJSInt32 = DataFormatJS | DataFormatInt32,
    … …  
    7979    case DataFormatStorage:
    8080        return "Storage";
     81    case DataFormatBigInt32:
     82        return "BigInt32";
    8183    case DataFormatJS:
    8284        return "JS";
    … …  
    8991    case DataFormatJSBoolean:
    9092        return "JSBoolean";
     93    case DataFormatJSBigInt32:
     94        return "JSBigInt32";
    9195    case DataFormatDead:
    9296        return "Dead";

  • trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp

    r260660 r260674  
    23362336    case DataFormatJSBoolean:
    23372337    case DataFormatJSDouble:
     2338    case DataFormatJSBigInt32:
    23382339        return GeneratedOperandJSValue;
    23392340
Note: See TracChangeset for help on using the changeset viewer.