Changeset 260727 in webkit

Timestamp:

Apr 26, 2020 11:55:20 AM (4 years ago)

Author:

jh718.park@samsung.com

Message:

[WTF] Workaround gcc bug for unsigned bitfield related usual arithmetic conversions
​https://bugs.webkit.org/show_bug.cgi?id=211044

Reviewed by Darin Adler.

• wtf/URL.cpp:

(WTF::URL::setHost):
(WTF::URL::setHostAndPort):
(WTF::URL::setUser):
(WTF::URL::setPassword):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/URL.cpp (modified) (4 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2020-04-26  Joonghun Park  <jh718.park@samsung.com>
+
+        [WTF] Workaround gcc bug for unsigned bitfield related usual arithmetic conversions
+        https://bugs.webkit.org/show_bug.cgi?id=211044
+
+        Reviewed by Darin Adler.
+
+        * wtf/URL.cpp:
+        (WTF::URL::setHost):
+        (WTF::URL::setHostAndPort):
+        (WTF::URL::setUser):
+        (WTF::URL::setPassword):
+
 2020-04-25  Joonghun Park  <jh718.park@samsung.com>
 

trunk/Source/WTF/wtf/URL.cpp

@@ -437 +437 @@
         return;
 
-    bool slashSlashNeeded = m_userStart == static_cast<unsigned>(m_schemeEnd + 1);
+    bool slashSlashNeeded = m_userStart == m_schemeEnd + 1U;
     parse(makeString(
         StringView(m_string).left(hostStart()),
@@ -487 +487 @@
         return;
 
-    bool slashSlashNeeded = m_userStart == static_cast<unsigned>(m_schemeEnd + 1);
+    bool slashSlashNeeded = m_userStart == m_schemeEnd + 1U;
     parse(makeString(
         StringView(m_string).left(hostStart()),
@@ -548 +548 @@
     unsigned end = m_userEnd;
     if (!newUser.isEmpty()) {
-        bool slashSlashNeeded = m_userStart == static_cast<unsigned>(m_schemeEnd + 1);
+        bool slashSlashNeeded = m_userStart == m_schemeEnd + 1U;
         bool needSeparator = end == m_hostEnd || (end == m_passwordEnd && m_string[end] != '@');
         parse(makeString(
@@ -571 +571 @@
 
     if (!newPassword.isEmpty()) {
-        bool needLeadingSlashes = m_userEnd == static_cast<unsigned>(m_schemeEnd + 1);
+        bool needLeadingSlashes = m_userEnd == m_schemeEnd + 1U;
         parse(makeString(
             StringView(m_string).left(m_userEnd),