Changeset 260733 in webkit

Timestamp:

Apr 26, 2020 3:54:45 PM (4 years ago)

Author:

Alexey Shvayka

Message:

Symbol should have Construct? internal method
​https://bugs.webkit.org/show_bug.cgi?id=211050

Reviewed by Yusuke Suzuki.

JSTests:

• stress/is-constructor.js:
• test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

This change introduces constructSymbol() method, which unconditionally throws
a TypeError, since its presence is observable when, for example, Symbol is a
ProxyTarget? itself [1]. Aligns JSC with the spec [2], V8, and SpiderMonkey.

[1]: ​https://tc39.es/ecma262/#sec-proxycreate (step 7.b)
[2]: ​https://tc39.es/ecma262/#constructor

• runtime/SymbolConstructor.cpp:

(JSC::SymbolConstructor::SymbolConstructor):
(JSC::constructSymbol):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/is-constructor.js (modified) (3 diffs)
• JSTests/test262/expectations.yaml (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/SymbolConstructor.cpp (modified) (2 diffs)

trunk/JSTests/ChangeLog

@@ +1 @@
+2020-04-26  Alexey Shvayka  <shvaikalesh@gmail.com>
+
+        Symbol should have [[Construct]] internal method
+        https://bugs.webkit.org/show_bug.cgi?id=211050
+
+        Reviewed by Yusuke Suzuki.
+
+        * stress/is-constructor.js:
+        * test262/expectations.yaml: Mark 2 test cases as passing.
+
 2020-04-26  Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/JSTests/stress/is-constructor.js

@@ -38 +38 @@
 assert(isConstructor(Set));
 assert(isConstructor(String));
+assert(isConstructor(Symbol));
 assert(isConstructor(WeakMap));
 assert(isConstructor(WeakSet));
@@ -66 +67 @@
 assert(!isConstructor(Array.prototype));
 
-// Symbol is not a constructor.
-assert(!isConstructor(Symbol));
-
 // Getters / setters are not constructors.
 assert(!isConstructor(Object.getOwnPropertyDescriptor({get f(){}}, "f").get));
@@ -92 +90 @@
 assert(!isConstructor(JSON.stringify));
 assert(!isConstructor(Promise.all));
+assert(!isConstructor(Proxy.revocable));
 assert(!isConstructor(Symbol.for));
 assert(!isConstructor(Array.prototype.push));
 
 // Proxy and bound functions carry forward non-constructor-ness.
-assert(!isConstructor(new Proxy(Symbol, {})));
+assert(isConstructor(new Proxy(Symbol, {})));
+assert(isConstructor(Symbol.bind(null)));
 assert(!isConstructor(new Proxy(Math.cos, {})));
-assert(!isConstructor(Symbol.bind(null)));
 assert(!isConstructor(Math.cos.bind(null)));

trunk/JSTests/test262/expectations.yaml

@@ -1616 +1616 @@
   default: 'TypeError: null is not a function'
   strict mode: 'TypeError: null is not a function'
-test/built-ins/Symbol/is-constructor.js:
-  default: 'Test262Error: Expected true but got false'
-  strict mode: 'Test262Error: Expected true but got false'
 test/built-ins/ThrowTypeError/extensible.js:
   default: 'Test262Error: Expected SameValue(«true», «false») to be true'

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-04-26  Alexey Shvayka  <shvaikalesh@gmail.com>
+
+        Symbol should have [[Construct]] internal method
+        https://bugs.webkit.org/show_bug.cgi?id=211050
+
+        Reviewed by Yusuke Suzuki.
+
+        This change introduces constructSymbol() method, which unconditionally throws
+        a TypeError, since its presence is observable when, for example, Symbol is a
+        [[ProxyTarget]] itself [1]. Aligns JSC with the spec [2], V8, and SpiderMonkey.
+
+        [1]: https://tc39.es/ecma262/#sec-proxycreate (step 7.b)
+        [2]: https://tc39.es/ecma262/#constructor
+
+        * runtime/SymbolConstructor.cpp:
+        (JSC::SymbolConstructor::SymbolConstructor):
+        (JSC::constructSymbol):
+
 2020-04-26  Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/Source/JavaScriptCore/runtime/SymbolConstructor.cpp

@@ -58 +58 @@
 
 static EncodedJSValue JSC_HOST_CALL callSymbol(JSGlobalObject*, CallFrame*);
+static EncodedJSValue JSC_HOST_CALL constructSymbol(JSGlobalObject*, CallFrame*);
 
 SymbolConstructor::SymbolConstructor(VM& vm, Structure* structure)
-    : InternalFunction(vm, structure, callSymbol, nullptr)
+    : InternalFunction(vm, structure, callSymbol, constructSymbol)
 {
 }
@@ -90 +91 @@
     RETURN_IF_EXCEPTION(scope, { });
     return JSValue::encode(Symbol::createWithDescription(vm, string));
+}
+
+static EncodedJSValue JSC_HOST_CALL constructSymbol(JSGlobalObject* globalObject, CallFrame* callFrame)
+{
+    VM& vm = globalObject->vm();
+    auto scope = DECLARE_THROW_SCOPE(vm);
+    return throwVMError(globalObject, scope, createNotAConstructorError(globalObject, callFrame->jsCallee()));
 }