Changeset 260761 in webkit

Timestamp:

Apr 27, 2020 9:31:30 AM (4 years ago)

Author:

Nikita Vasilyev

Message:

REGRESSION (r258730): Web Inspector: Sidebar tabs have incorrect tabIndex
​https://bugs.webkit.org/show_bug.cgi?id=211072
<rdar://problem/62445067>

Reviewed by Brian Burg.

Only selected radio button should be focusable. This matches native macOS radio buttons.

• UserInterface/Views/RadioButtonNavigationItem.js:

(WI.RadioButtonNavigationItem.prototype.get tabbable):
This getter was incorrectly returning -1 or 0 instead of a boolean value.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/RadioButtonNavigationItem.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-04-27  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        REGRESSION (r258730): Web Inspector: Sidebar tabs have incorrect tabIndex
+        https://bugs.webkit.org/show_bug.cgi?id=211072
+        <rdar://problem/62445067>
+
+        Reviewed by Brian Burg.
+
+        Only selected radio button should be focusable. This matches native macOS radio buttons.
+
+        * UserInterface/Views/RadioButtonNavigationItem.js:
+        (WI.RadioButtonNavigationItem.prototype.get tabbable):
+        This getter was incorrectly returning -1 or 0 instead of a boolean value.
+
 2020-04-27  Diego Pino Garcia  <dpino@igalia.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/RadioButtonNavigationItem.js

@@ -70 +70 @@
     get tabbable()
     {
-        return this.selected ? 0 : -1;
+        return this.selected;
     }
 };