Changeset 260811 in webkit

Timestamp:

Apr 27, 2020 11:59:02 PM (4 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK][WebInspector] platformSave broken when running within the Flatpak runtime
​https://bugs.webkit.org/show_bug.cgi?id=209473

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-04-27
Reviewed by Adrian Perez de Castro.

• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox): White-list the user document
folder into the sandbox. This seems needed by the file-chooser
popup, somehow.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• flatpak/flatpakutils.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-04-27  Philippe Normand  <pnormand@igalia.com>
+
+        [GTK][WebInspector] platformSave broken when running within the Flatpak runtime
+        https://bugs.webkit.org/show_bug.cgi?id=209473
+
+        Reviewed by Adrian Perez de Castro.
+
+        * flatpak/flatpakutils.py:
+        (WebkitFlatpak.run_in_sandbox): White-list the user document
+        folder into the sandbox. This seems needed by the file-chooser
+        popup, somehow.
+
 2020-04-27  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/flatpak/flatpakutils.py

@@ -660 +660 @@
             ])
 
+            try:
+                with open(os.devnull, 'w') as devnull:
+                    uid = subprocess.check_output(("id", "-u"), stderr=devnull).strip()
+                    flatpak_command.append("--bind-mount=/run/user/{uid}/doc=/run/user/{uid}/doc".format(uid=uid))
+            except subprocess.CalledProcessError:
+                pass
+
             forwarded.update({
                 "TZ": "PST8PDT",