Changeset 260825 in webkit

Timestamp:

Apr 28, 2020 7:49:04 AM (4 years ago)

Author:

Claudio Saavedra

Message:

[Linux] Replace --geometry with --fullscreen when using MiniBrowser for WebDriver tests
​https://bugs.webkit.org/show_bug.cgi?id=211123

Reviewed by Carlos Alberto Lopez Perez.

MiniBrowser's --geometry is on its way out, so use --fullscreen
instead as it does the job.

• Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:

(GTKMiniBrowserDriver.launch_url):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-04-28  Claudio Saavedra  <csaavedra@igalia.com>
+
+        [Linux] Replace --geometry with --fullscreen when using MiniBrowser for WebDriver tests
+        https://bugs.webkit.org/show_bug.cgi?id=211123
+
+        Reviewed by Carlos Alberto Lopez Perez.
+
+        MiniBrowser's --geometry is on its way out, so use --fullscreen
+        instead as it does the job.
+
+        * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
+        (GTKMiniBrowserDriver.launch_url):
+
 2020-04-27  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py

@@ -36 +36 @@
         if self.process_name.endswith('run-minibrowser'):
             self._browser_arguments.append('--gtk')
-        self._browser_arguments.append('--geometry={w}x{h}'.format(w=self._screen_size().width, h=self._screen_size().height))
+        self._browser_arguments.append('--full-screen')
         self._browser_arguments.append(url)
         super(GTKMiniBrowserDriver, self).launch_url(url, options, browser_build_path, browser_path)