Changeset 261276 in webkit
- Timestamp:
- May 7, 2020 2:05:36 AM (4 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r261275 r261276 1 2020-05-07 Adrian Perez de Castro <aperez@igalia.com> 2 3 [GTK4] Stop using the GtkWidget.destroy vfunc 4 https://bugs.webkit.org/show_bug.cgi?id=211553 5 6 Reviewed by Carlos Garcia Campos. 7 8 No new tests needed. 9 10 * UIProcess/API/gtk/WebKitWebViewBase.cpp: 11 (webkitWebViewBaseDestroy): Removed. 12 (webkitWebViewBaseDispose): Bring in the code from the removed function, adapt 13 to use g_clear_pointer() to destroy the nested dialog. 14 (webkit_web_view_base_class_init): Do not set the GtkWidget.destroy vfunc. 15 1 16 2020-05-07 Philippe Normand <pnormand@igalia.com> 2 17 -
trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
r261230 r261276 587 587 { 588 588 WebKitWebViewBase* webView = WEBKIT_WEB_VIEW_BASE(gobject); 589 g_clear_pointer(&webView->priv->dialog, gtk_widget_destroy); 589 590 webkitWebViewBaseSetToplevelOnScreenWindow(webView, nullptr); 590 591 if (webView->priv->accessible) … … 1662 1663 } 1663 1664 1664 static void webkitWebViewBaseDestroy(GtkWidget* widget)1665 {1666 WebKitWebViewBasePrivate* priv = WEBKIT_WEB_VIEW_BASE(widget)->priv;1667 if (priv->dialog)1668 gtk_widget_destroy(priv->dialog);1669 1670 GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->destroy(widget);1671 }1672 1673 1665 static void webkitWebViewBaseConstructed(GObject* object) 1674 1666 { … … 1771 1763 widgetClass->hierarchy_changed = webkitWebViewBaseHierarchyChanged; 1772 1764 #endif 1773 widgetClass->destroy = webkitWebViewBaseDestroy;1774 1765 1775 1766 GObjectClass* gobjectClass = G_OBJECT_CLASS(webkitWebViewBaseClass);
Note: See TracChangeset
for help on using the changeset viewer.