Changeset 261343 in webkit


Ignore:
Timestamp:
May 7, 2020 4:17:26 PM (4 years ago)
Author:
youenn@apple.com
Message:

Remove AudioMediaStreamTrackRenderer::muted
​https://bugs.webkit.org/show_bug.cgi?id=211289

Reviewed by Eric Carlson.

Source/WebCore:

  • platform/mediastream/AudioMediaStreamTrackRenderer.h:

muted is unnecessary since we are using start/stop instead.

Source/WebKit:

muted is unnecessary since we are using start/stop instead.

  • GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:
  • GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
  • GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.messages.in:
  • WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp:
  • WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.h:
Location:
trunk/Source
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r261342 r261343  
     12020-05-07  Youenn Fablet  <youenn@apple.com>
     2
     3        Remove AudioMediaStreamTrackRenderer::muted
     4        https://bugs.webkit.org/show_bug.cgi?id=211289
     5
     6        Reviewed by Eric Carlson.
     7
     8        * platform/mediastream/AudioMediaStreamTrackRenderer.h:
     9        muted is unnecessary since we are using start/stop instead.
     10
    1112020-05-07  Eric Carlson  <eric.carlson@apple.com>
    212

  • trunk/Source/WebCore/platform/mediastream/AudioMediaStreamTrackRenderer.h

    r261063 r261343  
    5151    virtual void pushSamples(const WTF::MediaTime&, const PlatformAudioData&, const AudioStreamDescription&, size_t) = 0;
    5252
    53     virtual void setMuted(bool);
    5453    virtual void setVolume(float);
    5554    float volume() const;
    … …  
    7170#endif
    7271
    73     bool isMuted() const;
    74 
    7572private:
    7673    static RendererCreator m_rendererCreator;
    7774
    7875    // Main thread writable members
    79     bool m_muted { false };
    8076    float m_volume { 1 };
    8177
    … …  
    8581#endif
    8682};
    87 
    88 inline void AudioMediaStreamTrackRenderer::setMuted(bool value)
    89 {
    90     m_muted = value;
    91 }
    9283
    9384inline void AudioMediaStreamTrackRenderer::setVolume(float volume)
    … …  
    9990{
    10091    return m_volume;
    101 }
    102 
    103 
    104 inline bool AudioMediaStreamTrackRenderer::isMuted() const
    105 {
    106     return m_muted;
    10792}
    10893

  • trunk/Source/WebKit/ChangeLog

    r261333 r261343  
     12020-05-07  Youenn Fablet  <youenn@apple.com>
     2
     3        Remove AudioMediaStreamTrackRenderer::muted
     4        https://bugs.webkit.org/show_bug.cgi?id=211289
     5
     6        Reviewed by Eric Carlson.
     7
     8        muted is unnecessary since we are using start/stop instead.
     9
     10        * GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:
     11        * GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
     12        * GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.messages.in:
     13        * WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp:
     14        * WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.h:
     15
    1162020-05-07  Don Olmstead  <don.olmstead@sony.com>
    217

  • trunk/Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp

    r257542 r261343  
    9191}
    9292
    93 void RemoteAudioMediaStreamTrackRenderer::setMuted(bool value)
    94 {
    95     m_renderer->setMuted(value);
    96 }
    97 
    9893void RemoteAudioMediaStreamTrackRenderer::setVolume(float value)
    9994{

  • trunk/Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h

    r254562 r261343  
    5656    void stop();
    5757    void clear();
    58     void setMuted(bool);
    5958    void setVolume(float);
    6059    void audioSamplesStorageChanged(const SharedMemory::Handle&, const WebCore::CAAudioStreamDescription&, uint64_t numberOfFrames);

  • trunk/Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.messages.in

    r254562 r261343  
    2929    Clear()
    3030
    31     SetMuted(bool value)
    3231    SetVolume(float value)
    3332

  • trunk/Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp

    r254562 r261343  
    7474}
    7575
    76 void AudioMediaStreamTrackRenderer::setMuted(bool value)
    77 {
    78     WebCore::AudioMediaStreamTrackRenderer::setMuted(value);
    79     m_connection->send(Messages::RemoteAudioMediaStreamTrackRenderer::SetMuted { value }, m_identifier);
    80 }
    81 
    8276void AudioMediaStreamTrackRenderer::setVolume(float value)
    8377{

  • trunk/Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.h

    r254562 r261343  
    5757    void stop() final;
    5858    void clear() final;
    59     void setMuted(bool) final;
    6059    void setVolume(float) final;
    6160    void pushSamples(const MediaTime&, const WebCore::PlatformAudioData&, const WebCore::AudioStreamDescription&, size_t) final;
Note: See TracChangeset for help on using the changeset viewer.