Changeset 261593 in webkit
- Timestamp:
- May 12, 2020 5:51:21 PM (4 years ago)
- Location:
- branches/safari-609-branch
- Files:
-
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
branches/safari-609-branch
-
branches/safari-609-branch/Source/JavaScriptCore/ChangeLog
r261591 r261593 1 2020-05-12 Mark Lam <mark.lam@apple.com> 2 3 Cherry-pick r261549. rdar://problem/63156073 4 5 2020-05-12 Mark Lam <mark.lam@apple.com> 6 7 Wasm::enableFastMemory() was called too late. 8 https://bugs.webkit.org/show_bug.cgi?id=211773 9 10 Reviewed by Yusuke Suzuki. 11 12 If Wasm fast memory is to be enabled, we should just do it in initializeThreading() 13 just like for all the other signal handlers that need to be initialized for JSC. 14 This simplifies its initialization and ensures that it is done in a timely manner 15 before Configs are frozen. 16 17 * jsc.cpp: 18 (jscmain): 19 * runtime/InitializeThreading.cpp: 20 (JSC::initializeThreading): 21 1 22 2020-05-12 Mark Lam <mark.lam@apple.com> 2 23 -
branches/safari-609-branch/Source/JavaScriptCore/jsc.cpp
r253867 r261593 1 1 /* 2 2 * Copyright (C) 1999-2000 Harri Porten (porten@kde.org) 3 * Copyright (C) 2004-20 19Apple Inc. All rights reserved.3 * Copyright (C) 2004-2020 Apple Inc. All rights reserved. 4 4 * Copyright (C) 2006 Bjoern Graf (bjoern.graf@gmail.com) 5 5 * … … 75 75 #include "WasmCapabilities.h" 76 76 #include "WasmContext.h" 77 #include "WasmFaultSignalHandler.h"78 77 #include "WasmMemory.h" 79 78 #include <locale.h> … … 3139 3138 JSC::initializeThreading(); 3140 3139 initializeTimeoutIfNeeded(); 3141 #if ENABLE(WEBASSEMBLY)3142 JSC::Wasm::enableFastMemory();3143 #endif3144 3140 3145 3141 bool gigacageDisableRequested = false; -
branches/safari-609-branch/Source/JavaScriptCore/runtime/InitializeThreading.cpp
r261591 r261593 48 48 #include "WasmCalleeRegistry.h" 49 49 #include "WasmCapabilities.h" 50 #include "WasmFaultSignalHandler.h" 50 51 #include "WasmThunks.h" 51 52 #include "WriteBarrier.h" … … 105 106 #endif 106 107 VMTraps::initializeSignals(); 108 #if ENABLE(WEBASSEMBLY) 109 Wasm::enableFastMemory(); 110 #endif 107 111 108 112 WTF::compilerFence(); -
branches/safari-609-branch/Source/WebKit
- Property svn:mergeinfo changed
/trunk/Source/WebKit (added) merged: 261549
- Property svn:mergeinfo changed
-
branches/safari-609-branch/Source/WebKit/ChangeLog
r261578 r261593 1 2020-05-12 Mark Lam <mark.lam@apple.com> 2 3 Cherry-pick r261549. rdar://problem/63156073 4 5 2020-05-12 Mark Lam <mark.lam@apple.com> 6 7 Wasm::enableFastMemory() was called too late. 8 https://bugs.webkit.org/show_bug.cgi?id=211773 9 10 Reviewed by Yusuke Suzuki. 11 12 Previously, we were calling Wasm::enableFastMemory() in WebProcess::initializeWebProcess(). 13 By then, it is too late because the JSC::Config and WTF::Config have already been 14 frozen. There is nothing special about Wasm::enableFastMemory() that it needs to 15 be called this late. This patch moves it into JSC::initializeThreading() where 16 it belongs. 17 18 This change also make the initialization of Wasm fast memory consistent with how 19 we have always done it for the jsc shell i.e. it is initialized at the end of 20 JSC::initializeThreading(). 21 22 * WebProcess/WebProcess.cpp: 23 (WebKit::WebProcess::initializeWebProcess): 24 1 25 2020-05-12 Alan Coon <alancoon@apple.com> 2 26 -
branches/safari-609-branch/Source/WebKit/WebProcess/WebProcess.cpp
r258924 r261593 81 81 #include <JavaScriptCore/JSLock.h> 82 82 #include <JavaScriptCore/MemoryStatistics.h> 83 #include <JavaScriptCore/WasmFaultSignalHandler.h>84 83 #include <WebCore/AXObjectCache.h> 85 84 #include <WebCore/ApplicationCacheStorage.h> … … 453 452 #endif 454 453 455 #if ENABLE(WEBASSEMBLY)456 JSC::Wasm::enableFastMemory();457 #endif458 459 454 #if ENABLE(RESOURCE_LOAD_STATISTICS) && !RELEASE_LOG_DISABLED 460 455 WebResourceLoadObserver::setShouldLogUserInteraction(parameters.shouldLogUserInteraction);
Note: See TracChangeset
for help on using the changeset viewer.