Changeset 261692 in webkit

Timestamp:

May 14, 2020 8:30:31 AM (4 years ago)

Author:

Andres Gonzalez

Message:

AXIsolatedObject::isOnScreen needs to be dispatched to the main thread.
​https://bugs.webkit.org/show_bug.cgi?id=211893

Reviewed by Chris Fleizach.

Covered by existing tests.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::children): Split assert into two lines for readability.
(WebCore::AXIsolatedObject::isOnScreen const): Forward to associated AXObject and dispatch to the main thread.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/isolatedtree/AXIsolatedObject.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-05-14  Andres Gonzalez  <andresg_22@apple.com>
+
+        AXIsolatedObject::isOnScreen needs to be dispatched to the main thread.
+        https://bugs.webkit.org/show_bug.cgi?id=211893
+
+        Reviewed by Chris Fleizach.
+
+        Covered by existing tests.
+
+        * accessibility/isolatedtree/AXIsolatedObject.cpp:
+        (WebCore::AXIsolatedObject::children): Split assert into two lines for readability.
+        (WebCore::AXIsolatedObject::isOnScreen const): Forward to associated AXObject and dispatch to the main thread.
+
 2020-05-14  Andres Gonzalez  <andresg_22@apple.com>
 

trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp

@@ -488 +488 @@
 const AXCoreObject::AccessibilityChildrenVector& AXIsolatedObject::children(bool)
 {
-    ASSERT(_AXSIsolatedTreeModeFunctionIsAvailable() && ((_AXSIsolatedTreeMode_Soft() == AXSIsolatedTreeModeSecondaryThread && !isMainThread()) || (_AXSIsolatedTreeMode_Soft() == AXSIsolatedTreeModeMainThread && isMainThread())));
+    ASSERT(_AXSIsolatedTreeModeFunctionIsAvailable() && ((_AXSIsolatedTreeMode_Soft() == AXSIsolatedTreeModeSecondaryThread && !isMainThread())
+        || (_AXSIsolatedTreeMode_Soft() == AXSIsolatedTreeModeMainThread && isMainThread())));
     updateBackingStore();
     m_children.clear();
@@ -1148 +1149 @@
 bool AXIsolatedObject::isOnScreen() const
 {
-    ASSERT_NOT_REACHED();
-    return false;
+    return Accessibility::retrieveValueFromMainThread<bool>([this] () -> bool {
+        if (auto* object = associatedAXObject())
+            return object->isOnScreen();
+        return false;
+    });
 }