Changeset 261693 in webkit

Timestamp:

May 14, 2020 8:31:58 AM (4 years ago)

Author:

Andres Gonzalez

Message:

Fix for crash in LayoutTest in isolated tree mode.
​https://bugs.webkit.org/show_bug.cgi?id=211894

Reviewed by Chris Fleizach.

Several LayoutTests.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]): Check backing object for nullity before dereferencing.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/mac/WebAccessibilityObjectWrapperMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-05-14  Andres Gonzalez  <andresg_22@apple.com>
+
+        Fix for crash in LayoutTest in isolated tree mode.
+        https://bugs.webkit.org/show_bug.cgi?id=211894
+
+        Reviewed by Chris Fleizach.
+
+        Several LayoutTests.
+
+        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+        (-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]): Check backing object for nullity before dereferencing.
+
 2020-05-14  Andres Gonzalez  <andresg_22@apple.com>
 

trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

@@ -4513 +4513 @@
             WebAccessibilityObjectWrapper* wrapper = children[index];
             // The attachment view should be returned, otherwise AX palindrome errors occur.
-            BOOL isAttachment = [wrapper isKindOfClass:[WebAccessibilityObjectWrapper class]] && wrapper.axBackingObject->isAttachment() && [wrapper attachmentView];
+            BOOL isAttachment = [wrapper isKindOfClass:[WebAccessibilityObjectWrapper class]] && wrapper.axBackingObject && wrapper.axBackingObject->isAttachment() && [wrapper attachmentView];
             [subarray addObject:isAttachment ? [wrapper attachmentView] : wrapper];
         }