Changeset 261728 in webkit

Timestamp:

May 14, 2020 7:00:30 PM (4 years ago)

Author:

Devin Rousso

Message:

[ESNext] enable logical assignment operators by default
​https://bugs.webkit.org/show_bug.cgi?id=211921

Reviewed by Yusuke Suzuki.

JSTests:

• test262/config.yaml:
• stress/logical-assignment-operator-and.js:
• stress/logical-assignment-operator-coalesce.js:
• stress/logical-assignment-operator-or.js:

Source/JavaScriptCore:

• runtime/OptionsList.h:
• parser/Lexer.cpp:

(JSC::Lexer<T>::lexWithoutClearingLineTerminator):
Remove useLogicalAssignmentOperators option.

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/logical-assignment-operator-and.js (modified) (1 diff)
• JSTests/stress/logical-assignment-operator-coalesce.js (modified) (1 diff)
• JSTests/stress/logical-assignment-operator-or.js (modified) (1 diff)
• JSTests/test262/config.yaml (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/parser/Lexer.cpp (modified) (3 diffs)
• Source/JavaScriptCore/runtime/OptionsList.h (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2020-05-14  Devin Rousso  <drousso@apple.com>
+
+        [ESNext] enable logical assignment operators by default
+        https://bugs.webkit.org/show_bug.cgi?id=211921
+
+        Reviewed by Yusuke Suzuki.
+
+        * test262/config.yaml:
+        * stress/logical-assignment-operator-and.js:
+        * stress/logical-assignment-operator-coalesce.js:
+        * stress/logical-assignment-operator-or.js:
+
 2020-05-14  Keith Miller  <keith_miller@apple.com>
 

trunk/JSTests/stress/logical-assignment-operator-and.js

@@ -1 @@
-//@ runLogicalAssignmentOperatorsEnabled
-
 function shouldBe(func, expected) {
     let actual = func();

trunk/JSTests/stress/logical-assignment-operator-coalesce.js

@@ -1 @@
-//@ runLogicalAssignmentOperatorsEnabled
-
 function shouldBe(func, expected) {
     let actual = func();

trunk/JSTests/stress/logical-assignment-operator-or.js

@@ -1 @@
-//@ runLogicalAssignmentOperatorsEnabled
-
 function shouldBe(func, expected) {
     let actual = func();

trunk/JSTests/test262/config.yaml

@@ -7 +7 @@
   WeakRef: useWeakRefs
   class-fields-public: usePublicClassFields
-  logical-assignment-operators: useLogicalAssignmentOperators
 skip:
   features:

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-05-14  Devin Rousso  <drousso@apple.com>
+
+        [ESNext] enable logical assignment operators by default
+        https://bugs.webkit.org/show_bug.cgi?id=211921
+
+        Reviewed by Yusuke Suzuki.
+
+        * runtime/OptionsList.h:
+        * parser/Lexer.cpp:
+        (JSC::Lexer<T>::lexWithoutClearingLineTerminator):
+        Remove `useLogicalAssignmentOperators` option.
+
 2020-05-14  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/JavaScriptCore/parser/Lexer.cpp

@@ -2087 +2087 @@
         if (m_current == '&') {
             shift();
-            if (UNLIKELY(Options::useLogicalAssignmentOperators() && m_current == '=')) {
+            if (m_current == '=') {
                 shift();
                 token = ANDEQUAL;
@@ -2129 +2129 @@
         if (m_current == '|') {
             shift();
-            if (UNLIKELY(Options::useLogicalAssignmentOperators() && m_current == '=')) {
+            if (m_current == '=') {
                 shift();
                 token = OREQUAL;
@@ -2170 +2170 @@
         if (m_current == '?') {
             shift();
-            if (UNLIKELY(Options::useLogicalAssignmentOperators() && m_current == '=')) {
+            if (m_current == '=') {
                 shift();
                 token = COALESCEEQUAL;

trunk/Source/JavaScriptCore/runtime/OptionsList.h

@@ -507 +507 @@
     v(Unsigned, getByValICMaxNumberOfIdentifiers, 4, Normal, "Number of identifiers we see in the LLInt that could cause us to bail on generating an IC for get_by_val.") \
     v(Bool, usePublicClassFields, true, Normal, "If true, the parser will understand public data fields inside classes.") \
-    v(Bool, useLogicalAssignmentOperators, false, Normal, "Enable support for \?\?=, ||=, and &&= logical assignment operators.") \
     v(Bool, useRandomizingExecutableIslandAllocation, false, Normal, "For the arm64 ExecutableAllocator, if true, select which region to use randomly. This is useful for testing that jump islands work.") \