Changeset 261744 in webkit


Ignore:
Timestamp:
May 15, 2020 7:40:51 AM (4 years ago)
Author:
aboya@igalia.com
Message:

[GStreamer][MediaStream] Fix missing video size
​https://bugs.webkit.org/show_bug.cgi?id=211938

Reviewed by Philippe Normand.

Source/WebCore:

r261683 redefined m_currentVideoStreamId. Under the new design, tracks
have several states:

  • "wanted": a track has been selected from JavaScript, or chosen by default.
  • "requested": a track that is expected to be chosen by the next STREAMS_SELECTED message.
  • "current": a track that has been selected after the STREAMS_SELECTED message has been handled.

naturalSize() used to check m_currentVideoStreamId to look for the
video size, but this is called relatively early before the track
becomes "current" under the new design.

Since the size tags can't be queried at any time, it makes sense to
use m_wantedVideoStreamId instead.

This fixes the following tests which were previously regressed:

fast/mediastream/get-user-media-constraints.html
fast/mediastream/getUserMedia-video-rescaling.html
fast/mediastream/mediastreamtrack-video-clone.html
imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-firstframe.https.html
fast/mediastream/media-stream-renders-first-frame.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::naturalSize const):

LayoutTests:

Updated test expectations.

  • platform/gtk/TestExpectations:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r261742 r261744  
     12020-05-15  Alicia Boya García  <aboya@igalia.com>
     2
     3        [GStreamer][MediaStream] Fix missing video size
     4        https://bugs.webkit.org/show_bug.cgi?id=211938
     5
     6        Reviewed by Philippe Normand.
     7
     8        Updated test expectations.
     9
     10        * platform/gtk/TestExpectations:
     11
    1122020-05-15  Antti Koivisto  <antti@apple.com>
    213

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r261738 r261744  
    14001400webkit.org/b/211887 webgl/1.0.3/conformance/textures/texture-size-limit.html [ Failure ]
    14011401
    1402 webkit.org/b/211938 fast/mediastream/get-user-media-constraints.html [ Failure ]
    1403 webkit.org/b/211938 fast/mediastream/getUserMedia-video-rescaling.html [ Failure ]
    1404 webkit.org/b/211938 imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-firstframe.https.html [ Failure ]
    1405 
    14061402webkit.org/b/211940 fast/text/multiple-codeunit-vertical-upright.html [ ImageOnlyFailure ]
    14071403webkit.org/b/211940 fast/text/multiple-codeunit-vertical-upright-2.html [ ImageOnlyFailure ]
    … …  
    15001496
    15011497# Bug 211938 is Failure.
    1502 webkit.org/b/199440 webkit.org/b/211938 fast/mediastream/mediastreamtrack-video-clone.html [ Pass Failure Crash ]
     1498webkit.org/b/199440 fast/mediastream/mediastreamtrack-video-clone.html [ Pass Crash ]
    15031499
    15041500# Known issues that were fixed by the WebKitMediaSrc rework that is now reverted.
    … …  
    33423338webkit.org/b/211569 media/video-presentation-mode.html [ Skip ]
    33433339
    3344 webkit.org/b/211938 fast/mediastream/media-stream-renders-first-frame.html [ Timeout ]
    3345 
    33463340#////////////////////////////////////////////////////////////////////////////////////////
    33473341# End of Tests timing out

  • trunk/Source/WebCore/ChangeLog

    r261742 r261744  
     12020-05-15  Alicia Boya García  <aboya@igalia.com>
     2
     3        [GStreamer][MediaStream] Fix missing video size
     4        https://bugs.webkit.org/show_bug.cgi?id=211938
     5
     6        Reviewed by Philippe Normand.
     7
     8        r261683 redefined m_currentVideoStreamId. Under the new design, tracks
     9        have several states:
     10
     11        - "wanted": a track has been selected from JavaScript, or chosen by
     12          default.
     13
     14        - "requested": a track that is expected to be chosen by the next
     15          STREAMS_SELECTED message.
     16
     17        - "current": a track that has been selected after the STREAMS_SELECTED
     18          message has been handled.
     19
     20        naturalSize() used to check m_currentVideoStreamId to look for the
     21        video size, but this is called relatively early before the track
     22        becomes "current" under the new design.
     23
     24        Since the size tags can't be queried at any time, it makes sense to
     25        use m_wantedVideoStreamId instead.
     26
     27        This fixes the following tests which were previously regressed:
     28
     29        fast/mediastream/get-user-media-constraints.html
     30        fast/mediastream/getUserMedia-video-rescaling.html
     31        fast/mediastream/mediastreamtrack-video-clone.html
     32        imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-firstframe.https.html
     33        fast/mediastream/media-stream-renders-first-frame.html
     34
     35        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
     36        (WebCore::MediaPlayerPrivateGStreamer::naturalSize const):
     37
    1382020-05-15  Antti Koivisto  <antti@apple.com>
    239

  • trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

    r261683 r261744  
    16671667
    16681668#if ENABLE(MEDIA_STREAM)
    1669     if (!m_isLegacyPlaybin && !m_currentVideoStreamId.isEmpty()) {
    1670         RefPtr<VideoTrackPrivateGStreamer> videoTrack = m_videoTracks.get(m_currentVideoStreamId);
     1669    if (!m_isLegacyPlaybin && !m_wantedVideoStreamId.isEmpty()) {
     1670        RefPtr<VideoTrackPrivateGStreamer> videoTrack = m_videoTracks.get(m_wantedVideoStreamId);
    16711671
    16721672        if (videoTrack) {
Note: See TracChangeset for help on using the changeset viewer.