Changeset 261744 in webkit
- Timestamp:
- May 15, 2020 7:40:51 AM (4 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r261742 r261744 1 2020-05-15 Alicia Boya García <aboya@igalia.com> 2 3 [GStreamer][MediaStream] Fix missing video size 4 https://bugs.webkit.org/show_bug.cgi?id=211938 5 6 Reviewed by Philippe Normand. 7 8 Updated test expectations. 9 10 * platform/gtk/TestExpectations: 11 1 12 2020-05-15 Antti Koivisto <antti@apple.com> 2 13 -
trunk/LayoutTests/platform/gtk/TestExpectations
r261738 r261744 1400 1400 webkit.org/b/211887 webgl/1.0.3/conformance/textures/texture-size-limit.html [ Failure ] 1401 1401 1402 webkit.org/b/211938 fast/mediastream/get-user-media-constraints.html [ Failure ]1403 webkit.org/b/211938 fast/mediastream/getUserMedia-video-rescaling.html [ Failure ]1404 webkit.org/b/211938 imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-firstframe.https.html [ Failure ]1405 1406 1402 webkit.org/b/211940 fast/text/multiple-codeunit-vertical-upright.html [ ImageOnlyFailure ] 1407 1403 webkit.org/b/211940 fast/text/multiple-codeunit-vertical-upright-2.html [ ImageOnlyFailure ] … … 1500 1496 1501 1497 # Bug 211938 is Failure. 1502 webkit.org/b/199440 webkit.org/b/211938 fast/mediastream/mediastreamtrack-video-clone.html [ Pass FailureCrash ]1498 webkit.org/b/199440 fast/mediastream/mediastreamtrack-video-clone.html [ Pass Crash ] 1503 1499 1504 1500 # Known issues that were fixed by the WebKitMediaSrc rework that is now reverted. … … 3342 3338 webkit.org/b/211569 media/video-presentation-mode.html [ Skip ] 3343 3339 3344 webkit.org/b/211938 fast/mediastream/media-stream-renders-first-frame.html [ Timeout ]3345 3346 3340 #//////////////////////////////////////////////////////////////////////////////////////// 3347 3341 # End of Tests timing out -
trunk/Source/WebCore/ChangeLog
r261742 r261744 1 2020-05-15 Alicia Boya García <aboya@igalia.com> 2 3 [GStreamer][MediaStream] Fix missing video size 4 https://bugs.webkit.org/show_bug.cgi?id=211938 5 6 Reviewed by Philippe Normand. 7 8 r261683 redefined m_currentVideoStreamId. Under the new design, tracks 9 have several states: 10 11 - "wanted": a track has been selected from JavaScript, or chosen by 12 default. 13 14 - "requested": a track that is expected to be chosen by the next 15 STREAMS_SELECTED message. 16 17 - "current": a track that has been selected after the STREAMS_SELECTED 18 message has been handled. 19 20 naturalSize() used to check m_currentVideoStreamId to look for the 21 video size, but this is called relatively early before the track 22 becomes "current" under the new design. 23 24 Since the size tags can't be queried at any time, it makes sense to 25 use m_wantedVideoStreamId instead. 26 27 This fixes the following tests which were previously regressed: 28 29 fast/mediastream/get-user-media-constraints.html 30 fast/mediastream/getUserMedia-video-rescaling.html 31 fast/mediastream/mediastreamtrack-video-clone.html 32 imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-firstframe.https.html 33 fast/mediastream/media-stream-renders-first-frame.html 34 35 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: 36 (WebCore::MediaPlayerPrivateGStreamer::naturalSize const): 37 1 38 2020-05-15 Antti Koivisto <antti@apple.com> 2 39 -
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
r261683 r261744 1667 1667 1668 1668 #if ENABLE(MEDIA_STREAM) 1669 if (!m_isLegacyPlaybin && !m_ currentVideoStreamId.isEmpty()) {1670 RefPtr<VideoTrackPrivateGStreamer> videoTrack = m_videoTracks.get(m_ currentVideoStreamId);1669 if (!m_isLegacyPlaybin && !m_wantedVideoStreamId.isEmpty()) { 1670 RefPtr<VideoTrackPrivateGStreamer> videoTrack = m_videoTracks.get(m_wantedVideoStreamId); 1671 1671 1672 1672 if (videoTrack) {
Note: See TracChangeset
for help on using the changeset viewer.