Changeset 261747 in webkit

Timestamp:

May 15, 2020 9:44:30 AM (4 years ago)

Author:

mark.lam@apple.com

Message:

Remove debugging dataLogs in LinkBuffer::copyCompactAndLinkCode() for release builds.
​https://bugs.webkit.org/show_bug.cgi?id=211961
<rdar://problem/63264848>

Reviewed by Keith Miller.

• assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::copyCompactAndLinkCode):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/LinkBuffer.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-05-15  Mark Lam  <mark.lam@apple.com>
+
+        Remove debugging dataLogs in LinkBuffer::copyCompactAndLinkCode() for release builds.
+        https://bugs.webkit.org/show_bug.cgi?id=211961
+        <rdar://problem/63264848>
+
+        Reviewed by Keith Miller.
+
+        * assembler/LinkBuffer.cpp:
+        (JSC::LinkBuffer::copyCompactAndLinkCode):
+
 2020-05-15  Paulo Matos  <pmatos@igalia.com>
 

trunk/Source/JavaScriptCore/assembler/LinkBuffer.cpp

@@ -238 +238 @@
 #if CPU(ARM64E) && ENABLE(FAST_JIT_PERMISSIONS)
     if (verifyUncompactedHash.finalHash() != expectedFinalHash) {
+#ifndef NDEBUG
         dataLogLn("Hashes don't match: ", RawPointer(bitwise_cast<void*>(static_cast<uintptr_t>(verifyUncompactedHash.finalHash()))), " ", RawPointer(bitwise_cast<void*>(static_cast<uintptr_t>(expectedFinalHash))));
         dataLogLn("Crashing!");
+#endif
         CRASH();
     }