Changeset 261915 in webkit

Timestamp:

May 20, 2020 6:30:42 AM (4 years ago)

Author:

youenn@apple.com

Message:

[Mac] Use preferedPixelBufferFormat for AVVideoCaptureSource
​https://bugs.webkit.org/show_bug.cgi?id=212071

Reviewed by Eric Carlson.

Source/WebCore:

Manually tested.

• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::avVideoCapturePixelBufferFormat):

Source/WTF:

• wtf/PlatformHave.h:

Add HAVE_DISPLAY_LAYER_BIPLANAR_SUPPORT macro.

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/PlatformHave.h (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2020-05-20  Youenn Fablet  <youenn@apple.com>
+
+        [Mac] Use preferedPixelBufferFormat for AVVideoCaptureSource
+        https://bugs.webkit.org/show_bug.cgi?id=212071
+
+        Reviewed by Eric Carlson.
+
+        * wtf/PlatformHave.h:
+        Add HAVE_DISPLAY_LAYER_BIPLANAR_SUPPORT macro.
+
 2020-05-19  Adrian Perez de Castro  <aperez@igalia.com>
 

trunk/Source/WTF/wtf/PlatformHave.h

@@ -619 +619 @@
 #define HAVE_QUICKLOOK_THUMBNAILING 1
 #endif
+
+#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600)
+#define HAVE_DISPLAY_LAYER_BIPLANAR_SUPPORT 1
+#endif

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-05-20  Youenn Fablet  <youenn@apple.com>
+
+        [Mac] Use preferedPixelBufferFormat for AVVideoCaptureSource
+        https://bugs.webkit.org/show_bug.cgi?id=212071
+
+        Reviewed by Eric Carlson.
+
+        Manually tested.
+
+        * platform/mediastream/mac/AVVideoCaptureSource.mm:
+        (WebCore::avVideoCapturePixelBufferFormat):
+
 2020-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm

@@ -76 +76 @@
 static inline OSType avVideoCapturePixelBufferFormat()
 {
-    // FIXME: Use preferedPixelBufferFormat() once rdar://problem/44391444 is fixed.
-#if PLATFORM(MAC)
+#if HAVE(DISPLAY_LAYER_BIPLANAR_SUPPORT)
+    return preferedPixelBufferFormat();
+#else
     return kCVPixelFormatType_420YpCbCr8Planar;
-#else
-    return preferedPixelBufferFormat();
 #endif
 }