Changeset 262077 in webkit

Timestamp:

May 22, 2020 2:54:32 PM (4 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Storage: don't request the list of IndexedDB database names multiple times for the same security origin
​https://bugs.webkit.org/show_bug.cgi?id=212253
<rdar://problem/62945903>

Reviewed by Joseph Pecoraro.

This can happen if additional frames are added that share the same security origin as the
main frame. Simply maintain a Set of security origins that've already been requested for
and ignore any repeat requests.

• UserInterface/Controllers/IndexedDBManager.js:

(WI.IndexedDBManager):
(WI.IndexedDBManager.prototype._reset):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/IndexedDBManager.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-05-22  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Storage: don't request the list of IndexedDB database names multiple times for the same security origin
+        https://bugs.webkit.org/show_bug.cgi?id=212253
+        <rdar://problem/62945903>
+
+        Reviewed by Joseph Pecoraro.
+
+        This can happen if additional frames are added that share the same security origin as the
+        main frame. Simply maintain a `Set` of security origins that've already been requested for
+        and ignore any repeat requests.
+
+        * UserInterface/Controllers/IndexedDBManager.js:
+        (WI.IndexedDBManager):
+        (WI.IndexedDBManager.prototype._reset):
+
 2020-05-20  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/IndexedDBManager.js

@@ -34 +34 @@
 
         this._enabled = false;
+        this._requestedSecurityOrigins = new Set;
+
         this._reset();
     }
@@ -152 +154 @@
     {
         this._indexedDatabases = [];
+        this._requestedSecurityOrigins.clear();
         this.dispatchEventToListeners(WI.IndexedDBManager.Event.Cleared);
 
@@ -173 +176 @@
         if (!securityOrigin || securityOrigin === "://")
             return;
+
+        if (this._requestedSecurityOrigins.has(securityOrigin))
+            return;
+
+        this._requestedSecurityOrigins.add(securityOrigin);
 
         function processDatabaseNames(error, names)