Changeset 262179 in webkit

Timestamp:

May 26, 2020 10:19:45 PM (4 years ago)

Author:

commit-queue@webkit.org

Message:

MacApplication::isSafari should allow safari bundle id variants
​https://bugs.webkit.org/show_bug.cgi?id=212401

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-05-26
Reviewed by Timothy Hatcher.

There is a test environment with bundle ID com.apple.Safari.something.
This change is blocking rdar://problem/63574451

• platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::MacApplication::isSafari):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/cocoa/RuntimeApplicationChecksCocoa.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-05-26  Alex Christensen  <achristensen@webkit.org>
+
+        MacApplication::isSafari should allow safari bundle id variants
+        https://bugs.webkit.org/show_bug.cgi?id=212401
+
+        Reviewed by Timothy Hatcher.
+
+        There is a test environment with bundle ID com.apple.Safari.something.
+        This change is blocking rdar://problem/63574451
+
+        * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+        (WebCore::MacApplication::isSafari):
+
 2020-05-26  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm

@@ -97 +97 @@
 bool MacApplication::isSafari()
 {
-    static bool isSafari = applicationBundleIsEqualTo("com.apple.Safari"_s) || applicationBundleIsEqualTo("com.apple.SafariTechnologyPreview"_s);
+    static bool isSafari = applicationBundleIsEqualTo("com.apple.Safari"_s)
+        || applicationBundleIsEqualTo("com.apple.SafariTechnologyPreview"_s)
+        || applicationBundleIdentifier().startsWith("com.apple.Safari.");
     return isSafari;
 }