Changeset 262476 in webkit

Timestamp:

Jun 2, 2020, 9:54:21 PM (5 years ago)

Author:

Simon Fraser

Message:

EventRegion::translate() needs to offset the wheel event regions
​https://bugs.webkit.org/show_bug.cgi?id=212683

Reviewed by Zalan Bujtas.

Source/WebCore:

EventRegion::translate() failed to offset the wheel event regions, which resulted
in wrong reasons for GraphicsLayers with a non-zero offsetFromRenderer.

Test: fast/scrolling/mac/wheel-event-listener-region-layer-offset.html

• rendering/EventRegion.cpp:

(WebCore::EventRegion::translate):

LayoutTests:

• fast/scrolling/mac/wheel-event-listener-region-layer-offset-expected.txt: Added.
• fast/scrolling/mac/wheel-event-listener-region-layer-offset.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/scrolling/mac/wheel-event-listener-region-inside-overflow-scroll-expected.txt (modified) (1 diff)
• LayoutTests/fast/scrolling/mac/wheel-event-listener-region-layer-offset-expected.txt (added)
• LayoutTests/fast/scrolling/mac/wheel-event-listener-region-layer-offset.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/EventRegion.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-06-02  Simon Fraser  <simon.fraser@apple.com>
+
+        EventRegion::translate() needs to offset the wheel event regions
+        https://bugs.webkit.org/show_bug.cgi?id=212683
+
+        Reviewed by Zalan Bujtas.
+
+        * fast/scrolling/mac/wheel-event-listener-region-layer-offset-expected.txt: Added.
+        * fast/scrolling/mac/wheel-event-listener-region-layer-offset.html: Added.
+
 2020-06-02  Zalan Bujtas  <zalan@apple.com>
 

trunk/LayoutTests/fast/scrolling/mac/wheel-event-listener-region-inside-overflow-scroll-expected.txt

@@ -43 +43 @@
                     (rect (0,202) width=185 height=218)
                   (wheel event listener region
-                    (rect (22,22) width=100 height=400)
+                    (rect (20,20) width=100 height=400)
                     (non-passive
-                      (rect (22,22) width=100 height=400)
+                      (rect (20,20) width=100 height=400)
                     )
                   )

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-06-02  Simon Fraser  <simon.fraser@apple.com>
+
+        EventRegion::translate() needs to offset the wheel event regions
+        https://bugs.webkit.org/show_bug.cgi?id=212683
+
+        Reviewed by Zalan Bujtas.
+
+        EventRegion::translate() failed to offset the wheel event regions, which resulted 
+        in wrong reasons for GraphicsLayers with a non-zero offsetFromRenderer.
+
+        Test: fast/scrolling/mac/wheel-event-listener-region-layer-offset.html
+
+        * rendering/EventRegion.cpp:
+        (WebCore::EventRegion::translate):
+
 2020-06-02  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/rendering/EventRegion.cpp

@@ -147 +147 @@
 #endif
 
-    // FIXME: Translate m_wheelEventListenerRegion and m_nonPassiveWheelEventListenerRegion
+#if ENABLE(WHEEL_EVENT_REGIONS)
+    m_wheelEventListenerRegion.translate(offset);
+    m_nonPassiveWheelEventListenerRegion.translate(offset);
+#endif
 
 #if ENABLE(EDITABLE_REGION)