Changeset 263457 in webkit
- Timestamp:
- Jun 24, 2020 8:36:45 AM (4 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r263452 r263457 1 2020-06-24 Philippe Normand <pnormand@igalia.com> 2 3 [GStreamer] webrtc/disable-encryption.html is a crashing flaky 4 https://bugs.webkit.org/show_bug.cgi?id=211166 5 <rdar://problem/63223973> 6 7 Reviewed by Xabier Rodriguez-Calvar. 8 9 * platform/gtk/TestExpectations: Unflag webrtc/disable-encryption.html. 10 1 11 2020-06-24 Jacob Uphoff <jacob_uphoff@apple.com> 2 12 -
trunk/LayoutTests/platform/gtk/TestExpectations
r263440 r263457 2219 2219 webkit.org/b/211836 imported/w3c/web-platform-tests/fetch/api/abort/general.any.worker.html [ Failure Pass ] 2220 2220 2221 webkit.org/b/211166 webrtc/disable-encryption.html [ Crash Pass ]2222 2223 2221 webkit.org/b/212821 scrollbars/scrollbar-selectors.html [ Pass Timeout Missing ] 2224 2222 -
trunk/Source/WebCore/ChangeLog
r263455 r263457 1 2020-06-24 Philippe Normand <pnormand@igalia.com> 2 3 [GStreamer] webrtc/disable-encryption.html is a crashing flaky 4 https://bugs.webkit.org/show_bug.cgi?id=211166 5 <rdar://problem/63223973> 6 7 Reviewed by Xabier Rodriguez-Calvar. 8 9 Simplify the process to create internal appsrc elements. I suspect something bad was ongoing 10 with these moves of GRefPtr. 11 12 * platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: 13 (WebCore::_WebKitMediaStreamSrc::SourceData::ensureAppSrc): 14 (WebCore::webkitMediaStreamSrcSetupAppSrc): 15 (WebCore::_WebKitMediaStreamSrc::SourceData::setSrc): Deleted. 16 1 17 2020-06-24 Antti Koivisto <antti@apple.com> 2 18 -
trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp
r261685 r263457 220 220 } 221 221 222 void setSrc(GRefPtr<GstElement>&& src)222 void ensureAppSrc() 223 223 { 224 m_src = WTFMove(src); 224 ASSERT(!m_src); 225 m_src = gst_element_factory_make("appsrc", nullptr); 225 226 if (!GST_IS_APP_SRC(m_src.get())) 226 227 return; … … 589 590 GstStaticPadTemplate* pad_template, bool onlyTrack) 590 591 { 591 GRefPtr<GstElement> src = gst_element_factory_make("appsrc", nullptr); 592 data->setSrc(WTFMove(src)); 592 data->ensureAppSrc(); 593 593 if (track->isCaptureTrack()) 594 594 g_object_set(data->src(), "do-timestamp", true, nullptr);
Note: See TracChangeset
for help on using the changeset viewer.