Changeset 263631 in webkit
- Timestamp:
- Jun 27, 2020 10:26:28 PM (4 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r263628 r263631 1 2020-06-27 Zalan Bujtas <zalan@apple.com> 2 3 [LFC][IFC] Replaced inline boxes sit on the baseline with their margins 4 https://bugs.webkit.org/show_bug.cgi?id=213679 5 6 Reviewed by Antti Koivisto. 7 8 * fast/layoutformattingcontext/replaced-box-with-margin-on-baseline-expected.html: Added. 9 * fast/layoutformattingcontext/replaced-box-with-margin-on-baseline.html: Added. 10 1 11 2020-06-27 Mark Lam <mark.lam@apple.com> 2 12 -
trunk/Source/WebCore/ChangeLog
r263628 r263631 1 2020-06-27 Zalan Bujtas <zalan@apple.com> 2 3 [LFC][IFC] Replaced inline boxes sit on the baseline with their margins 4 https://bugs.webkit.org/show_bug.cgi?id=213679 5 6 Reviewed by Antti Koivisto. 7 8 Take the margin box into account when computing the top position of a baseline aligned replaced inline box. 9 10 Test: fast/layoutformattingcontext/replaced-box-with-margin-on-baseline.html 11 12 * layout/inlineformatting/InlineLineBuilder.cpp: 13 (WebCore::Layout::LineBuilder::alignContentVertically): 14 1 15 2020-06-27 Mark Lam <mark.lam@apple.com> 2 16 -
trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp
r258073 r263631 174 174 auto baselineOffsetFromMarginBox = boxGeometry.marginBefore() + boxGeometry.borderTop() + boxGeometry.paddingTop().valueOr(0) + inlineBlockBaselineOffset; 175 175 logicalTop = baselineOffset() - baselineOffsetFromMarginBox; 176 } else 177 logicalTop = baselineOffset() - run.logicalRect().height(); 176 } else { 177 auto& boxGeometry = formattingContext().geometryForBox(layoutBox); 178 logicalTop = baselineOffset() - (boxGeometry.verticalBorder() + boxGeometry.verticalPadding().valueOr(0_lu) + run.logicalRect().height() + boxGeometry.marginAfter()); 179 } 178 180 break; 179 181 case VerticalAlign::Top:
Note: See TracChangeset
for help on using the changeset viewer.