Changeset 263637 in webkit

Timestamp:

Jun 28, 2020 2:36:05 PM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Setting url.search="??" (two questionmarks) has incorrect behavior
​https://bugs.webkit.org/show_bug.cgi?id=170452

Patch by Rob Buis <​rbuis@igalia.com> on 2020-06-28
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update improved test result.

• web-platform-tests/url/url-setters-expected.txt:

Source/WebCore:

There is no need to strip leading "?" character since
URLParser expects it to be there. This differs from the
specification algorithm [1], which relies on state override,
which URLParser does not support.

Behavior matches Firefox and Chrome.

Test: imported/w3c/web-platform-tests/url/url-setters.html

[1] ​https://url.spec.whatwg.org/#dom-url-search

• html/URLDecomposition.cpp:

(WebCore::URLDecomposition::setSearch):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/url/url-setters-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/URLDecomposition.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2020-06-28  Rob Buis  <rbuis@igalia.com>
+
+        Setting url.search="??" (two questionmarks) has incorrect behavior
+        https://bugs.webkit.org/show_bug.cgi?id=170452
+
+        Reviewed by Darin Adler.
+
+        Update improved test result.
+
+        * web-platform-tests/url/url-setters-expected.txt:
+
 2020-06-27  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-expected.txt

@@ -541 +541 @@
 PASS <a>: Setting <https://example.net?lang=en-US#nav>.search = '?lang=fr' 
 PASS <area>: Setting <https://example.net?lang=en-US#nav>.search = '?lang=fr' 
-FAIL URL: Setting <https://example.net?lang=en-US#nav>.search = '??lang=fr' assert_equals: expected "https://example.net/??lang=fr#nav" but got "https://example.net/?lang=fr#nav"
-FAIL <a>: Setting <https://example.net?lang=en-US#nav>.search = '??lang=fr' assert_equals: expected "https://example.net/??lang=fr#nav" but got "https://example.net/?lang=fr#nav"
-FAIL <area>: Setting <https://example.net?lang=en-US#nav>.search = '??lang=fr' assert_equals: expected "https://example.net/??lang=fr#nav" but got "https://example.net/?lang=fr#nav"
+PASS URL: Setting <https://example.net?lang=en-US#nav>.search = '??lang=fr' 
+PASS <a>: Setting <https://example.net?lang=en-US#nav>.search = '??lang=fr' 
+PASS <area>: Setting <https://example.net?lang=en-US#nav>.search = '??lang=fr' 
 PASS URL: Setting <https://example.net?lang=en-US#nav>.search = '?' 
 PASS <a>: Setting <https://example.net?lang=en-US#nav>.search = '?' 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-06-28  Rob Buis  <rbuis@igalia.com>
+
+        Setting url.search="??" (two questionmarks) has incorrect behavior
+        https://bugs.webkit.org/show_bug.cgi?id=170452
+
+        Reviewed by Darin Adler.
+
+        There is no need to strip leading "?" character since
+        URLParser expects it to be there. This differs from the
+        specification algorithm [1], which relies on state override,
+        which URLParser does not support.
+
+        Behavior matches Firefox and Chrome.
+
+        Test: imported/w3c/web-platform-tests/url/url-setters.html
+
+        [1] https://url.spec.whatwg.org/#dom-url-search
+
+        * html/URLDecomposition.cpp:
+        (WebCore::URLDecomposition::setSearch):
+
 2020-06-28  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/WebCore/html/URLDecomposition.cpp

@@ -222 +222 @@
         fullURL.setQuery({ });
     } else {
-        String newSearch = value.startsWith('?') ? value.substring(1) : value;
+        String newSearch = value;
         // Make sure that '#' in the query does not leak to the hash.
         fullURL.setQuery(newSearch.replaceWithLiteral('#', "%23"));