Changeset 264296 in webkit

Timestamp:

Jul 13, 2020 1:51:45 AM (4 years ago)

Author:

calvaris@igalia.com

Message:

[GStreamer] Unreviewed, remove private debug code

When I landed the OpenCDM code I accidentally landed a couple of
things that were internal debug that is not useful upstream.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleSyncMessage):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-07-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [GStreamer] Unreviewed, remove private debug code
+
+        When I landed the OpenCDM code I accidentally landed a couple of
+        things that were internal debug that is not useful upstream.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::handleSyncMessage):
+        (WebCore::MediaPlayerPrivateGStreamer::handleMessage):
+
 2020-07-12  Darin Adler  <darin@apple.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -1597 +1597 @@
 bool MediaPlayerPrivateGStreamer::handleSyncMessage(GstMessage* message)
 {
-    if (GST_MESSAGE_TYPE(message) == GST_MESSAGE_ERROR && !g_strcmp0(g_getenv("WEBKIT_CRASH_ON_GSTREAMER_ERROR"), "sync")) {
-        GUniqueOutPtr<GError> err;
-        GUniqueOutPtr<gchar> debug;
-        gst_message_parse_error(message, &err.outPtr(), &debug.outPtr());
-        GST_ERROR("Error %d from %s: %s (url=%s)", err->code, GST_MESSAGE_SRC_NAME(message), err->message, m_url.string().utf8().data());
-        GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(m_pipeline.get()), GST_DEBUG_GRAPH_SHOW_ALL, "webkit-video-sync-error");
-        ASSERT_NOT_REACHED();
-    }
-
     if (GST_MESSAGE_TYPE(message) == GST_MESSAGE_STREAM_COLLECTION && !m_isLegacyPlaybin) {
         GRefPtr<GstStreamCollection> collection;
@@ -1879 +1870 @@
 
         GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(m_pipeline.get()), GST_DEBUG_GRAPH_SHOW_ALL, "webkit-video.error");
-
-        if (!g_strcmp0(g_getenv("WEBKIT_CRASH_ON_GSTREAMER_ERROR"), "async"))
-            CRASH();
 
         error = MediaPlayer::NetworkState::Empty;