Changeset 264481 in webkit

Timestamp:

Jul 16, 2020 2:59:33 PM (4 years ago)

Author:

Megan Gardner

Message:

Selection is not always clearing when tapping.
​https://bugs.webkit.org/show_bug.cgi?id=214326
Source/WebKit:

<rdar://problem/65069201>

Reviewed by Wenson Hsieh.

In r262280 we stopped the UIWKGestureOneFingerTap gesture from starting if the tap was not inside
the current selection. That caused the selection to not always be cleared, especially when tapping
on an element that could create an overlay in which the selection was supposed to be obscured. We
short circuited this gesture because it used to cause a sync IPC message to be sent to the web process,
but that code has subsequently changed, so allowing the gesture to start and clear the selection in all
cases is no longer a performance concern, so changing the behavior back to allowing the gesture to always
start, even if the touch is not inside the selection rect.

Test: editing/selection/ios/hide-selection-after-tap-on-prevent-default-element.html

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):

LayoutTests:

Reviewed by Wenson Hsieh.

• editing/selection/ios/hide-selection-after-tap-on-prevent-default-element-expected.txt: Added.
• editing/selection/ios/hide-selection-after-tap-on-prevent-default-element.html: Added.
• resources/ui-helper.js:

(window.UIHelper.tapElement):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/selection/ios/hide-selection-after-tap-on-prevent-default-element-expected.txt (added)
• LayoutTests/editing/selection/ios/hide-selection-after-tap-on-prevent-default-element.html (added)
• LayoutTests/resources/ui-helper.js (modified) (1 diff)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-07-16  Megan Gardner  <megan_gardner@apple.com>
+
+        Selection is not always clearing when tapping.
+        https://bugs.webkit.org/show_bug.cgi?id=214326
+
+        Reviewed by Wenson Hsieh.
+
+        * editing/selection/ios/hide-selection-after-tap-on-prevent-default-element-expected.txt: Added.
+        * editing/selection/ios/hide-selection-after-tap-on-prevent-default-element.html: Added.
+        * resources/ui-helper.js:
+        (window.UIHelper.tapElement):
+
 2020-07-16  Truitt Savell  <tsavell@apple.com>
 

trunk/LayoutTests/resources/ui-helper.js

@@ -128 +128 @@
                 });`, resolve);
         });
+    }
+
+    static tapElement(element, delay = 0)
+    {
+        const x = element.offsetLeft + (element.offsetWidth / 2);
+        const y = element.offsetTop + (element.offsetHeight / 2);
+        this.tapAt(x, y);
     }
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-07-16  Megan Gardner  <megan_gardner@apple.com>
+
+        Selection is not always clearing when tapping.
+        https://bugs.webkit.org/show_bug.cgi?id=214326
+        <rdar://problem/65069201>
+
+        Reviewed by Wenson Hsieh.
+
+        In r262280 we stopped the UIWKGestureOneFingerTap gesture from starting if the tap was not inside
+        the current selection. That caused the selection to not always be cleared, especially when tapping
+        on an element that could create an overlay in which the selection was supposed to be obscured. We 
+        short circuited this gesture because it used to cause a sync IPC message to be sent to the web process,
+        but that code has subsequently changed, so allowing the gesture to start and clear the selection in all
+        cases is no longer a performance concern, so changing the behavior back to allowing the gesture to always
+        start, even if the touch is not inside the selection rect.
+
+        Test: editing/selection/ios/hide-selection-after-tap-on-prevent-default-element.html
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
+
 2020-07-16  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -2586 +2586 @@
             }
             default:
-                if (!_page->editorState().selectionIsRange)
-                    return NO;
-                return [self _pointIsInsideSelectionRect:point outBoundingRect:nil];
+                return _page->editorState().selectionIsRange;
             }
         }