Changeset 264745 in webkit

Timestamp:

Jul 22, 2020 9:20:47 PM (4 years ago)

Author:

keith_miller@apple.com

Message:

iOS simulator does not support WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=191064

Reviewed by Yusuke Suzuki.

Now that it seems we can JIT in the Simulator we should enable
WebAssembly there. This just means enabling FTL/B3 so WASM gets
enabled.

• wtf/PlatformEnable.h:
• wtf/PlatformEnableCocoa.h:

Location:

trunk

Files:

• LayoutTests/platform/ios-simulator/TestExpectations (modified) (1 diff)
• Source/WTF/ChangeLog (modified) (1 diff)
• Source/WTF/wtf/PlatformEnable.h (modified) (1 diff)
• Source/WTF/wtf/PlatformEnableCocoa.h (modified) (1 diff)

trunk/LayoutTests/platform/ios-simulator/TestExpectations

@@ -41 +41 @@
 # we explicitly disallow this because this font is too slow.
 fast/text/initial-advance-in-intermediate-run-complex.html [ ImageOnlyFailure ]
-
-# Simulator doesn't support WebAssembly.
-http/tests/security/contentSecurityPolicy/WebAssembly-allowed.html [ Failure ]
-http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-about-blank-iframe.html [ Failure ]
-http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-external-script.html [ Failure ]
-http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-subframe.html [ Failure ]
-http/tests/security/contentSecurityPolicy/WebAssembly-blocked.html [ Failure ]
-imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/requires-failure.https.any.html [ Failure ]
-imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/requires-failure.https.any.serviceworker.html [ Failure ]
-imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/requires-success.any.worker.html [ Failure ]
-wasm/iframe-postmessage.html [ Skip ]
-wasm/iframe-parent-postmessage.html [ Skip ]
-wasm/window-postmessage.html [ Skip ]
-imported/w3c/web-platform-tests/encoding/encodeInto.any.html [ Skip ]
-imported/w3c/web-platform-tests/encoding/encodeInto.any.worker.html [ Skip ]
-imported/w3c/web-platform-tests/encoding/streams/decode-utf8.any.html [ Skip ]
-imported/w3c/web-platform-tests/encoding/streams/decode-utf8.any.worker.html [ Skip ]
-imported/w3c/web-platform-tests/encoding/textdecoder-copy.any.html [ Skip ]
-imported/w3c/web-platform-tests/encoding/textdecoder-copy.any.worker.html [ Skip ]
-imported/w3c/web-platform-tests/encoding/textdecoder-streaming.any.html [ Skip ]
-imported/w3c/web-platform-tests/encoding/textdecoder-streaming.any.worker.html [ Skip ]
 
 # These tests seem to fail due pixel rounding errors in the absolute positioned elements used as reference.

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2020-07-22  Keith Miller  <keith_miller@apple.com>
+
+        iOS simulator does not support WebAssembly
+        https://bugs.webkit.org/show_bug.cgi?id=191064
+
+        Reviewed by Yusuke Suzuki.
+
+        Now that it seems we can JIT in the Simulator we should enable
+        WebAssembly there. This just means enabling FTL/B3 so WASM gets
+        enabled.
+
+        * wtf/PlatformEnable.h:
+        * wtf/PlatformEnableCocoa.h:
+
 2020-07-22  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/WTF/wtf/PlatformEnable.h

@@ -611 +611 @@
 #endif
 
-/* FIXME: This should be turned into an #error invariant */
-/* The FTL is disabled on the iOS simulator, mostly for simplicity. */
-#if PLATFORM(IOS_FAMILY_SIMULATOR)
-#undef ENABLE_FTL_JIT
-#define ENABLE_FTL_JIT 0
-#endif
-
 /* If possible, try to enable a disassembler. This is optional. We proceed in two
    steps: first we try to find some disassembler that we can use, and then we

trunk/Source/WTF/wtf/PlatformEnableCocoa.h

@@ -205 +205 @@
 #endif
 
-#if !defined(ENABLE_FTL_JIT) && !USE(JSVALUE32_64) && !PLATFORM(IOS_FAMILY_SIMULATOR)
+#if !defined(ENABLE_FTL_JIT) && !USE(JSVALUE32_64)
 #define ENABLE_FTL_JIT 1
 #endif