Changeset 264801 in webkit


Ignore:
Timestamp:
Jul 23, 2020 3:33:57 PM (4 years ago)
Author:
keith_miller@apple.com
Message:

iOS simulator does not support WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=191064

Reviewed by Yusuke Suzuki.

Source/WTF:

Now that it seems we can JIT in the Simulator we should enable
WebAssembly there. This just means enabling FTL/B3 so WASM gets
enabled.

  • wtf/PlatformEnable.h:
  • wtf/PlatformEnableCocoa.h:

LayoutTests:

Remove simulator only expectations/failures now that WebAssembly is available in the simulator.

  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/imported/w3c/web-platform-tests/xhr/send-data-sharedarraybuffer.any-expected.txt:
  • platform/ios-simulator/imported/w3c/web-platform-tests/xhr/send-data-sharedarraybuffer.any.worker-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-copy-channel-expected.txt:
Location:
trunk
Files:
2 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r264798 r264801  
     12020-07-23  Keith Miller  <keith_miller@apple.com>
     2
     3        iOS simulator does not support WebAssembly
     4        https://bugs.webkit.org/show_bug.cgi?id=191064
     5
     6        Reviewed by Yusuke Suzuki.
     7
     8        Remove simulator only expectations/failures now that WebAssembly is available in the simulator.
     9
     10        * platform/ios-simulator/TestExpectations:
     11        * platform/ios-simulator/imported/w3c/web-platform-tests/xhr/send-data-sharedarraybuffer.any-expected.txt:
     12        * platform/ios-simulator/imported/w3c/web-platform-tests/xhr/send-data-sharedarraybuffer.any.worker-expected.txt:
     13        * platform/ios-wk2/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-copy-channel-expected.txt:
     14
    1152020-07-23  Ryan Haddad  <ryanhaddad@apple.com>
    216

  • trunk/LayoutTests/platform/ios-simulator/TestExpectations

    r264763 r264801  
    4141# we explicitly disallow this because this font is too slow.
    4242fast/text/initial-advance-in-intermediate-run-complex.html [ ImageOnlyFailure ]
    43 
    44 # Simulator doesn't support WebAssembly.
    45 http/tests/security/contentSecurityPolicy/WebAssembly-allowed.html [ Failure ]
    46 http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-about-blank-iframe.html [ Failure ]
    47 http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-external-script.html [ Failure ]
    48 http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-subframe.html [ Failure ]
    49 http/tests/security/contentSecurityPolicy/WebAssembly-blocked.html [ Failure ]
    50 imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/requires-failure.https.any.html [ Failure ]
    51 imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/requires-failure.https.any.serviceworker.html [ Failure ]
    52 imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/requires-success.any.worker.html [ Failure ]
    53 wasm/iframe-postmessage.html [ Skip ]
    54 wasm/iframe-parent-postmessage.html [ Skip ]
    55 wasm/window-postmessage.html [ Skip ]
    56 imported/w3c/web-platform-tests/encoding/encodeInto.any.html [ Skip ]
    57 imported/w3c/web-platform-tests/encoding/encodeInto.any.worker.html [ Skip ]
    58 imported/w3c/web-platform-tests/encoding/streams/decode-utf8.any.html [ Skip ]
    59 imported/w3c/web-platform-tests/encoding/streams/decode-utf8.any.worker.html [ Skip ]
    60 imported/w3c/web-platform-tests/encoding/textdecoder-copy.any.html [ Skip ]
    61 imported/w3c/web-platform-tests/encoding/textdecoder-copy.any.worker.html [ Skip ]
    62 imported/w3c/web-platform-tests/encoding/textdecoder-streaming.any.html [ Skip ]
    63 imported/w3c/web-platform-tests/encoding/textdecoder-streaming.any.worker.html [ Skip ]
    64 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-copy-channel.html [ Skip ]
    65 imported/w3c/web-platform-tests/xhr/send-data-sharedarraybuffer.any.html [ Skip ]
    66 imported/w3c/web-platform-tests/xhr/send-data-sharedarraybuffer.any.worker.html [ Skip ]
    6743
    6844# These tests seem to fail due pixel rounding errors in the absolute positioned elements used as reference.

  • trunk/Source/WTF/ChangeLog

    r264783 r264801  
     12020-07-23  Keith Miller  <keith_miller@apple.com>
     2
     3        iOS simulator does not support WebAssembly
     4        https://bugs.webkit.org/show_bug.cgi?id=191064
     5
     6        Reviewed by Yusuke Suzuki.
     7
     8        Now that it seems we can JIT in the Simulator we should enable
     9        WebAssembly there. This just means enabling FTL/B3 so WASM gets
     10        enabled.
     11
     12        * wtf/PlatformEnable.h:
     13        * wtf/PlatformEnableCocoa.h:
     14
    1152020-07-23  Aditya Keerthi  <akeerthi@apple.com>
    216

  • trunk/Source/WTF/wtf/PlatformEnable.h

    r264753 r264801  
    611611#endif
    612612
    613 /* FIXME: This should be turned into an #error invariant */
    614 /* The FTL is disabled on the iOS simulator, mostly for simplicity. */
    615 #if PLATFORM(IOS_FAMILY_SIMULATOR)
    616 #undef ENABLE_FTL_JIT
    617 #define ENABLE_FTL_JIT 0
    618 #endif
    619 
    620613/* If possible, try to enable a disassembler. This is optional. We proceed in two
    621614   steps: first we try to find some disassembler that we can use, and then we

  • trunk/Source/WTF/wtf/PlatformEnableCocoa.h

    r264753 r264801  
    205205#endif
    206206
    207 #if !defined(ENABLE_FTL_JIT) && !USE(JSVALUE32_64) && !PLATFORM(IOS_FAMILY_SIMULATOR)
     207#if !defined(ENABLE_FTL_JIT) && !USE(JSVALUE32_64)
    208208#define ENABLE_FTL_JIT 1
    209209#endif
Note: See TracChangeset for help on using the changeset viewer.