Changeset 264951 in webkit

Timestamp:

Jul 27, 2020 4:27:27 PM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Add output directory option to WebGL conformance import script
​https://bugs.webkit.org/show_bug.cgi?id=214856

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-07-27
Reviewed by Dean Jackson.

Add an -o / --ouptut-dir option to support revising the
LayoutTests/webgl/2.0.0 snapshot.

• webgl/generate-webgl-tests.py:

(main):

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• webgl/generate-webgl-tests.py (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-07-27  Kenneth Russell  <kbr@chromium.org>
+
+        Add output directory option to WebGL conformance import script
+        https://bugs.webkit.org/show_bug.cgi?id=214856
+
+        Reviewed by Dean Jackson.
+
+        Add an -o / --ouptut-dir option to support revising the
+        LayoutTests/webgl/2.0.0 snapshot.
+
+        * webgl/generate-webgl-tests.py:
+        (main):
+
 2020-07-24  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/LayoutTests/webgl/generate-webgl-tests.py

@@ -213 +213 @@
       "-e", "--generate-expectations", action="store_true",
       help="generatet the test expectations")
+  parser.add_option(
+      "-o", "--output-dir", dest="output_dir",
+      help="base directory for output. defaults to \'.\'",
+      default=".")
 
   (options, args) = parser.parse_args(args=argv)
@@ -223 +227 @@
 
   source_dir = options.source_dir;
-  webgl_tests_dir = "resources/webgl_test_files"
-  base_path = "."
+  output_dir = options.output_dir;
+  webgl_tests_dir = os.path.join(output_dir, "resources/webgl_test_files")
 
   # copy all the files from the WebGL conformance tests.
@@ -241 +245 @@
   for test in tests:
     url = os.path.relpath(test["url"], source_dir)
-    dst = url
+    dst = os.path.join(output_dir, url)
     dst_dir = os.path.dirname(dst)
     src = os.path.relpath(os.path.join(webgl_tests_dir, url), dst_dir).replace("\\", "/")
-    base_url = os.path.relpath(base_path, dst_dir).replace("\\", "/")
+    base_url = os.path.relpath(output_dir, dst_dir).replace("\\", "/")
     subs = {
       "url": src,