Changeset 264965 in webkit


Ignore:
Timestamp:
Jul 27, 2020 11:55:31 PM (4 years ago)
Author:
Carlos Garcia Campos
Message:

REGRESSION(r230479): [TextureMapper] replica layer is not rendered
​https://bugs.webkit.org/show_bug.cgi?id=214827

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Since r230479 the replica layer transform is not applied because m_layerTransforms.localTransform is never set
for the replica layer. We need to call applyAnimationsRecursively() on the replica layer to initialize the
localTransform (even when we know the replica layer won't have animations).

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::applyAnimationsRecursively):

LayoutTests:

Add missing expectations for compositing/reflections tests and rebaseline the existing ones.

  • platform/gtk/TestExpectations:
  • platform/gtk/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/gtk/compositing/reflections/animation-inside-reflection-expected.txt: Added.
  • platform/gtk/compositing/reflections/backface-hidden-reflection-expected.png: Added.
  • platform/gtk/compositing/reflections/become-simple-composited-reflection-expected.png: Added.
  • platform/gtk/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
  • platform/gtk/compositing/reflections/compositing-change-inside-reflection-expected.txt: Added.
  • platform/gtk/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/gtk/compositing/reflections/deeply-nested-reflections-expected.txt: Added.
  • platform/gtk/compositing/reflections/direct-image-object-fit-reflected-expected.txt: Added.
  • platform/gtk/compositing/reflections/load-video-in-reflection-expected.png: Added.
  • platform/gtk/compositing/reflections/load-video-in-reflection-expected.txt: Added.
  • platform/gtk/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
  • platform/gtk/compositing/reflections/masked-reflection-on-composited-expected.txt: Added.
  • platform/gtk/compositing/reflections/nested-reflection-anchor-point-expected.png: Added.
  • platform/gtk/compositing/reflections/nested-reflection-anchor-point-expected.txt: Added.
  • platform/gtk/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/gtk/compositing/reflections/nested-reflection-animated-expected.txt: Added.
  • platform/gtk/compositing/reflections/nested-reflection-expected.png: Added.
  • platform/gtk/compositing/reflections/nested-reflection-expected.txt: Added.
  • platform/gtk/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/gtk/compositing/reflections/nested-reflection-mask-change-expected.txt: Added.
  • platform/gtk/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
  • platform/gtk/compositing/reflections/nested-reflection-on-overflow-expected.txt: Added.
  • platform/gtk/compositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/gtk/compositing/reflections/nested-reflection-opacity-expected.txt: Added.
  • platform/gtk/compositing/reflections/nested-reflection-size-change-expected.png: Added.
  • platform/gtk/compositing/reflections/nested-reflection-size-change-expected.txt: Added.
  • platform/gtk/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/gtk/compositing/reflections/nested-reflection-transformed-expected.txt: Added.
  • platform/gtk/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/gtk/compositing/reflections/nested-reflection-transformed2-expected.txt: Added.
  • platform/gtk/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/gtk/compositing/reflections/nested-reflection-transition-expected.txt: Added.
  • platform/gtk/compositing/reflections/reflection-in-composited-expected.png:
  • platform/gtk/compositing/reflections/reflection-on-composited-expected.png: Added.
  • platform/gtk/compositing/reflections/reflection-on-composited-expected.txt: Added.
  • platform/gtk/compositing/reflections/reflection-opacity-expected.png: Added.
  • platform/gtk/compositing/reflections/reflection-opacity-expected.txt: Added.
  • platform/gtk/compositing/reflections/reflection-ordering-expected.png: Added.
  • platform/gtk/compositing/reflections/reflection-ordering-expected.txt: Added.
  • platform/gtk/compositing/reflections/reflection-positioning-expected.png: Added.
  • platform/gtk/compositing/reflections/reflection-positioning-expected.txt: Added.
  • platform/gtk/compositing/reflections/reflection-positioning2-expected.png: Added.
  • platform/gtk/compositing/reflections/reflection-positioning2-expected.txt: Added.
  • platform/gtk/compositing/reflections/remove-add-reflection-expected.png: Added.
  • platform/gtk/compositing/reflections/simple-composited-reflections-expected.png: Added.
  • platform/gtk/compositing/reflections/simple-composited-reflections-expected.txt: Added.
  • platform/gtk/compositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/gtk/compositing/reflections/transform-inside-reflection-expected.txt: Added.
Location:
trunk
Files:
48 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r264964 r264965  
     12020-07-27  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        REGRESSION(r230479): [TextureMapper] replica layer is not rendered
     4        https://bugs.webkit.org/show_bug.cgi?id=214827
     5
     6        Reviewed by Adrian Perez de Castro.
     7
     8        Add missing expectations for compositing/reflections tests and rebaseline the existing ones.
     9
     10        * platform/gtk/TestExpectations:
     11        * platform/gtk/compositing/reflections/animation-inside-reflection-expected.png: Added.
     12        * platform/gtk/compositing/reflections/animation-inside-reflection-expected.txt: Added.
     13        * platform/gtk/compositing/reflections/backface-hidden-reflection-expected.png: Added.
     14        * platform/gtk/compositing/reflections/become-simple-composited-reflection-expected.png: Added.
     15        * platform/gtk/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
     16        * platform/gtk/compositing/reflections/compositing-change-inside-reflection-expected.txt: Added.
     17        * platform/gtk/compositing/reflections/deeply-nested-reflections-expected.png: Added.
     18        * platform/gtk/compositing/reflections/deeply-nested-reflections-expected.txt: Added.
     19        * platform/gtk/compositing/reflections/direct-image-object-fit-reflected-expected.txt: Added.
     20        * platform/gtk/compositing/reflections/load-video-in-reflection-expected.png: Added.
     21        * platform/gtk/compositing/reflections/load-video-in-reflection-expected.txt: Added.
     22        * platform/gtk/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
     23        * platform/gtk/compositing/reflections/masked-reflection-on-composited-expected.txt: Added.
     24        * platform/gtk/compositing/reflections/nested-reflection-anchor-point-expected.png: Added.
     25        * platform/gtk/compositing/reflections/nested-reflection-anchor-point-expected.txt: Added.
     26        * platform/gtk/compositing/reflections/nested-reflection-animated-expected.png: Added.
     27        * platform/gtk/compositing/reflections/nested-reflection-animated-expected.txt: Added.
     28        * platform/gtk/compositing/reflections/nested-reflection-expected.png: Added.
     29        * platform/gtk/compositing/reflections/nested-reflection-expected.txt: Added.
     30        * platform/gtk/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
     31        * platform/gtk/compositing/reflections/nested-reflection-mask-change-expected.txt: Added.
     32        * platform/gtk/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
     33        * platform/gtk/compositing/reflections/nested-reflection-on-overflow-expected.txt: Added.
     34        * platform/gtk/compositing/reflections/nested-reflection-opacity-expected.png: Added.
     35        * platform/gtk/compositing/reflections/nested-reflection-opacity-expected.txt: Added.
     36        * platform/gtk/compositing/reflections/nested-reflection-size-change-expected.png: Added.
     37        * platform/gtk/compositing/reflections/nested-reflection-size-change-expected.txt: Added.
     38        * platform/gtk/compositing/reflections/nested-reflection-transformed-expected.png: Added.
     39        * platform/gtk/compositing/reflections/nested-reflection-transformed-expected.txt: Added.
     40        * platform/gtk/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
     41        * platform/gtk/compositing/reflections/nested-reflection-transformed2-expected.txt: Added.
     42        * platform/gtk/compositing/reflections/nested-reflection-transition-expected.png: Added.
     43        * platform/gtk/compositing/reflections/nested-reflection-transition-expected.txt: Added.
     44        * platform/gtk/compositing/reflections/reflection-in-composited-expected.png:
     45        * platform/gtk/compositing/reflections/reflection-on-composited-expected.png: Added.
     46        * platform/gtk/compositing/reflections/reflection-on-composited-expected.txt: Added.
     47        * platform/gtk/compositing/reflections/reflection-opacity-expected.png: Added.
     48        * platform/gtk/compositing/reflections/reflection-opacity-expected.txt: Added.
     49        * platform/gtk/compositing/reflections/reflection-ordering-expected.png: Added.
     50        * platform/gtk/compositing/reflections/reflection-ordering-expected.txt: Added.
     51        * platform/gtk/compositing/reflections/reflection-positioning-expected.png: Added.
     52        * platform/gtk/compositing/reflections/reflection-positioning-expected.txt: Added.
     53        * platform/gtk/compositing/reflections/reflection-positioning2-expected.png: Added.
     54        * platform/gtk/compositing/reflections/reflection-positioning2-expected.txt: Added.
     55        * platform/gtk/compositing/reflections/remove-add-reflection-expected.png: Added.
     56        * platform/gtk/compositing/reflections/simple-composited-reflections-expected.png: Added.
     57        * platform/gtk/compositing/reflections/simple-composited-reflections-expected.txt: Added.
     58        * platform/gtk/compositing/reflections/transform-inside-reflection-expected.png: Added.
     59        * platform/gtk/compositing/reflections/transform-inside-reflection-expected.txt: Added.
     60
    1612020-07-27  Antoine Quint  <graouts@webkit.org>
    262

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r264902 r264965  
    345345webkit.org/b/169918 compositing/plugins/no-backing-store.html [ Failure ]
    346346webkit.org/b/169918 compositing/plugins/small-to-large-composited-plugin.html [ Failure ]
    347 webkit.org/b/169918 compositing/reflections/direct-image-object-fit-reflected.html [ Failure ]
    348347webkit.org/b/169918 compositing/repaint/invalidations-on-composited-layers.html [ Failure ]
    349348webkit.org/b/169918 compositing/repaint/positioned-movement.html [ Failure ]
    … …  
    392391webkit.org/b/169918 compositing/text-on-scaled-surface.html [ ImageOnlyFailure ]
    393392webkit.org/b/169918 compositing/video/video-clip-change-src.html [ Crash ImageOnlyFailure Timeout ]
    394 webkit.org/b/169918 compositing/reflections/compositing-change-inside-reflection.html [ Missing Failure ]
    395 webkit.org/b/169918 compositing/reflections/deeply-nested-reflections.html [ Missing Failure ]
    396 webkit.org/b/169918 compositing/reflections/load-video-in-reflection.html [ Missing Failure ]
    397 webkit.org/b/169918 compositing/reflections/masked-reflection-on-composited.html [ Missing Failure ]
    398 webkit.org/b/169918 compositing/reflections/nested-reflection-anchor-point.html [ Missing Failure ]
    399 webkit.org/b/169918 compositing/reflections/nested-reflection-animated.html [ Missing Failure ]
    400 webkit.org/b/169918 compositing/reflections/nested-reflection-mask-change.html [ Missing Failure ]
    401 webkit.org/b/169918 compositing/reflections/nested-reflection-on-overflow.html [ Missing Failure ]
    402 webkit.org/b/169918 compositing/reflections/nested-reflection-opacity.html [ Missing Failure ]
    403 webkit.org/b/169918 compositing/reflections/nested-reflection-size-change.html [ Missing Failure ]
    404 webkit.org/b/169918 compositing/reflections/nested-reflection-transformed.html [ Missing Failure ]
    405 webkit.org/b/169918 compositing/reflections/nested-reflection-transformed2.html [ Missing Failure ]
    406 webkit.org/b/169918 compositing/reflections/nested-reflection-transition.html [ Missing Failure ]
    407 webkit.org/b/169918 compositing/reflections/nested-reflection.html [ Missing Failure ]
    408 webkit.org/b/169918 compositing/reflections/reflection-on-composited.html [ Missing Failure ]
    409 webkit.org/b/169918 compositing/reflections/reflection-opacity.html [ Missing Failure ]
    410 webkit.org/b/169918 compositing/reflections/reflection-ordering.html [ Missing Failure ]
    411 webkit.org/b/169918 compositing/reflections/reflection-positioning.html [ Missing Failure ]
    412 webkit.org/b/169918 compositing/reflections/reflection-positioning2.html [ Missing Failure ]
    413 webkit.org/b/169918 compositing/reflections/simple-composited-reflections.html [ Missing Failure ]
    414 webkit.org/b/169918 compositing/reflections/transform-inside-reflection.html [ Missing Failure ]
    415393webkit.org/b/169918 compositing/tiling/rotated-tiled-clamped.html [ Missing Failure ]
    416394webkit.org/b/169918 compositing/tiling/rotated-tiled-preserve3d-clamped.html [ Missing Failure ]
    … …  
    422400webkit.org/b/169918 compositing/webgl/webgl-reflection.html [ Missing Failure ]
    423401webkit.org/b/169918 compositing/plugins/composited-plugin.html [ Missing Failure ]
    424 webkit.org/b/169918 compositing/reflections/animation-inside-reflection.html [ Missing Failure ]
    425402webkit.org/b/169918 compositing/fixed-with-fixed-layout.html [ Crash ]
    426403webkit.org/b/169918 compositing/video/video-background-color.html [ Crash Pass ]

  • trunk/Source/WebCore/ChangeLog

    r264963 r264965  
     12020-07-27  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        REGRESSION(r230479): [TextureMapper] replica layer is not rendered
     4        https://bugs.webkit.org/show_bug.cgi?id=214827
     5
     6        Reviewed by Adrian Perez de Castro.
     7
     8        Since r230479 the replica layer transform is not applied because m_layerTransforms.localTransform is never set
     9        for the replica layer. We need to call applyAnimationsRecursively() on the replica layer to initialize the
     10        localTransform (even when we know the replica layer won't have animations).
     11
     12        * platform/graphics/texmap/TextureMapperLayer.cpp:
     13        (WebCore::TextureMapperLayer::applyAnimationsRecursively):
     14
    1152020-07-27  Alex Christensen  <achristensen@webkit.org>
    216

  • trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp

    r261422 r264965  
    693693{
    694694    bool hasRunningAnimations = syncAnimations(time);
     695    if (m_state.replicaLayer)
     696        hasRunningAnimations |= m_state.replicaLayer->applyAnimationsRecursively(time);
    695697    for (auto* child : m_children)
    696698        hasRunningAnimations |= child->applyAnimationsRecursively(time);
Note: See TracChangeset for help on using the changeset viewer.