Changeset 265131 in webkit

Timestamp:

Jul 30, 2020 9:49:30 PM (4 years ago)

Author:

Simon Fraser

Message:

Have TimingScope track the max event duration
​https://bugs.webkit.org/show_bug.cgi?id=215006

Reviewed by Tim Horton.

Have TimingScope track and print the longest event, as well as the count and
mean duration.

• wtf/TimingScope.cpp:

(WTF::TimingScope::scopeDidEnd):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/TimingScope.cpp (modified) (3 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2020-07-30  Simon Fraser  <simon.fraser@apple.com>
+
+        Have TimingScope track the max event duration
+        https://bugs.webkit.org/show_bug.cgi?id=215006
+
+        Reviewed by Tim Horton.
+
+        Have TimingScope track and print the longest event, as well as the count and
+        mean duration.
+
+        * wtf/TimingScope.cpp:
+        (WTF::TimingScope::scopeDidEnd):
+
 2020-07-30  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/WTF/wtf/TimingScope.cpp

@@ -42 +42 @@
         Seconds totalDuration;
         unsigned callCount { 0 };
+        Seconds maxDuration;
         
         Seconds meanDuration() const { return totalDuration / callCount; }
@@ -53 +54 @@
         auto& result = totals.add(name, CallData()).iterator->value;
         ++result.callCount;
+        result.maxDuration = std::max(result.maxDuration, duration);
         result.totalDuration += duration;
         return result;
@@ -74 +76 @@
     const auto& data = state().addToTotal(m_name, MonotonicTime::now() - m_startTime);
     if (!(data.callCount % m_logIterationInterval))
-        WTFLogAlways("%s: %u calls, mean duration: %.6fms, total duration: %.6fms", m_name, data.callCount, data.meanDuration().milliseconds(), data.totalDuration.milliseconds());
+        WTFLogAlways("%s: %u calls, mean duration: %.6fms, total duration: %.6fms, max duration %.6fms", m_name, data.callCount, data.meanDuration().milliseconds(), data.totalDuration.milliseconds(), data.maxDuration.milliseconds());
 }