Changeset 265140 in webkit


Ignore:
Timestamp:
Jul 31, 2020 8:36:02 AM (4 years ago)
Author:
aakash_jain@apple.com
Message:

[ews] Add unit-tests for various builder factories
https://bugs.webkit.org/show_bug.cgi?id=214969

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-build/factories_unittest.py: Added unit-tests.

(TestBuildFactory.test_generic_build_factory):
(TestBuildFactory.test_gtk_build_factory):
(TestBuildFactory.test_wpe_factory):
(TestBuildFactory.test_wincairo_factory):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/ews-build/factories_unittest.py

    r265082 r265140  
    158158
    159159class TestBuildFactory(TestCase):
     160    def test_generic_build_factory(self):
     161        factory = factories.BuildFactory(platform='mac-mojave', configuration='release', architectures=["x86_64"])
     162        self.assertBuildSteps(factory.steps, [
     163            _BuildStepFactory(steps.ConfigureBuild, platform='mac-mojave', configuration='release', architectures=["x86_64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
     164            _BuildStepFactory(steps.ValidatePatch),
     165            _BuildStepFactory(steps.PrintConfiguration),
     166            _BuildStepFactory(steps.CheckOutSource),
     167            _BuildStepFactory(steps.CheckOutSpecificRevision),
     168            _BuildStepFactory(steps.ApplyPatch),
     169            _BuildStepFactory(steps.KillOldProcesses),
     170            _BuildStepFactory(steps.CompileWebKit, skipUpload=False),
     171        ])
     172
    160173    def test_macos_build_factory(self):
    161174        factory = factories.macOSBuildFactory(platform='mac-mojave', configuration='release', architectures=["x86_64"])
     
    227240        self.assertBuildSteps(factory.steps, [
    228241            _BuildStepFactory(steps.ConfigureBuild, platform='tvos-13', configuration='release', architectures=["arm64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
     242            _BuildStepFactory(steps.ValidatePatch),
     243            _BuildStepFactory(steps.PrintConfiguration),
     244            _BuildStepFactory(steps.CheckOutSource),
     245            _BuildStepFactory(steps.CheckOutSpecificRevision),
     246            _BuildStepFactory(steps.ApplyPatch),
     247            _BuildStepFactory(steps.KillOldProcesses),
     248            _BuildStepFactory(steps.CompileWebKit, skipUpload=True),
     249        ])
     250
     251    def test_gtk_build_factory(self):
     252        factory = factories.GTKBuildFactory(platform='gtk', configuration='release', architectures=['x86_64'])
     253        self.assertBuildSteps(factory.steps, [
     254            _BuildStepFactory(steps.ConfigureBuild, platform='gtk', configuration='release', architectures=['x86_64'], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
     255            _BuildStepFactory(steps.ValidatePatch),
     256            _BuildStepFactory(steps.PrintConfiguration),
     257            _BuildStepFactory(steps.CheckOutSource),
     258            _BuildStepFactory(steps.CheckOutSpecificRevision),
     259            _BuildStepFactory(steps.ApplyPatch),
     260            _BuildStepFactory(steps.KillOldProcesses),
     261            _BuildStepFactory(steps.InstallGtkDependencies),
     262            _BuildStepFactory(steps.CompileWebKit, skipUpload=False),
     263        ])
     264
     265    def test_wpe_factory(self):
     266        factory = factories.WPEFactory(platform='wpe', configuration='release', architectures=['x86_64'])
     267        self.assertBuildSteps(factory.steps, [
     268            _BuildStepFactory(steps.ConfigureBuild, platform='wpe', configuration='release', architectures=['x86_64'], buildOnly=True, triggers=None, remotes=None, additionalArguments=None),
     269            _BuildStepFactory(steps.ValidatePatch),
     270            _BuildStepFactory(steps.PrintConfiguration),
     271            _BuildStepFactory(steps.CheckOutSource),
     272            _BuildStepFactory(steps.CheckOutSpecificRevision),
     273            _BuildStepFactory(steps.ApplyPatch),
     274            _BuildStepFactory(steps.KillOldProcesses),
     275            _BuildStepFactory(steps.InstallWpeDependencies),
     276            _BuildStepFactory(steps.CompileWebKit, skipUpload=True),
     277        ])
     278
     279    def test_wincairo_factory(self):
     280        factory = factories.WinCairoFactory(platform='wincairo', configuration='release', architectures=['x86_64'])
     281        self.assertBuildSteps(factory.steps, [
     282            _BuildStepFactory(steps.ConfigureBuild, platform='wincairo', configuration='release', architectures=['x86_64'], buildOnly=True, triggers=None, remotes=None, additionalArguments=None),
    229283            _BuildStepFactory(steps.ValidatePatch),
    230284            _BuildStepFactory(steps.PrintConfiguration),
  • trunk/Tools/ChangeLog

    r265128 r265140  
     12020-07-31  Aakash Jain  <aakash_jain@apple.com>
     2
     3        [ews] Add unit-tests for various builder factories
     4        https://bugs.webkit.org/show_bug.cgi?id=214969
     5
     6        Reviewed by Jonathan Bedard.
     7
     8        * BuildSlaveSupport/ews-build/factories_unittest.py: Added unit-tests.
     9        (TestBuildFactory.test_generic_build_factory):
     10        (TestBuildFactory.test_gtk_build_factory):
     11        (TestBuildFactory.test_wpe_factory):
     12        (TestBuildFactory.test_wincairo_factory):
     13
    1142020-07-30  Jonathan Bedard  <jbedard@apple.com>
    215
Note: See TracChangeset for help on using the changeset viewer.