Changeset 265154 in webkit

Timestamp:

Jul 31, 2020 12:24:08 PM (4 years ago)

Author:

sbarati@apple.com

Message:

Re-enable NO_SMT on Catalina
​https://bugs.webkit.org/show_bug.cgi?id=215024

Reviewed by Alexey Proskuryakov.

• runtime/Options.cpp:

(JSC::defaultTCSMValue):

• runtime/OptionsList.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/Options.cpp (modified) (1 diff)
• runtime/OptionsList.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-07-31  Saam Barati  <sbarati@apple.com>
+
+        Re-enable NO_SMT on Catalina
+        https://bugs.webkit.org/show_bug.cgi?id=215024
+
+        Reviewed by Alexey Proskuryakov.
+
+        * runtime/Options.cpp:
+        (JSC::defaultTCSMValue):
+        * runtime/OptionsList.h:
+
 2020-07-31  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/runtime/Options.cpp

@@ -229 +229 @@
 {
     return computeNumberOfWorkerThreads(maxNumberOfGCMarkers);
+}
+
+static bool defaultTCSMValue()
+{
+#if CPU(X86_64) && ((PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 110000) || (PLATFORM(MACCATALYST) && __IPHONE_OS_VERSION_MIN_REQUIRED < 140000))
+    return true;
+#else
+    return false;
+#endif
 }
 

trunk/Source/JavaScriptCore/runtime/OptionsList.h

@@ -77 +77 @@
 
 #define FOR_EACH_JSC_OPTION(v)                                          \
-    v(Bool, useKernTCSM, false, Normal, "Note: this needs to go before other options since they depend on this value.") \
+    v(Bool, useKernTCSM, defaultTCSMValue(), Normal, "Note: this needs to go before other options since they depend on this value.") \
     v(Bool, validateOptions, false, Normal, "crashes if mis-typed JSC options were passed to the VM") \
     v(Unsigned, dumpOptions, 0, Normal, "dumps JSC options (0 = None, 1 = Overridden only, 2 = All, 3 = Verbose)") \