Changeset 266931 in webkit

Timestamp:

Sep 11, 2020 11:53:24 AM (4 years ago)

Author:

jer.noble@apple.com

Message:

[iOS] Add Experimental setting to disable calling PID Inheritance API.
​https://bugs.webkit.org/show_bug.cgi?id=216387
<rdar://problem/66286777>

Reviewed by Eric Carlson.

Source/WebCore:

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setDisableMediaExperiencePIDInheritance):
(WebCore::RuntimeEnabledFeatures::disableMediaExperiencePIDInheritance const):

• page/Settings.yaml:
• platform/audio/ios/MediaSessionHelperIOS.mm:

(MediaSessionHelperiOS::providePresentingApplicationPID):

Source/WebKit:

• Shared/WebPreferences.yaml:

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/RuntimeEnabledFeatures.h (modified) (2 diffs)
• WebCore/page/Settings.yaml (modified) (1 diff)
• WebCore/platform/audio/ios/MediaSessionHelperIOS.mm (modified) (2 diffs)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/Shared/WebPreferences.yaml (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-11  Jer Noble  <jer.noble@apple.com>
+
+        [iOS] Add Experimental setting to disable calling PID Inheritance API.
+        https://bugs.webkit.org/show_bug.cgi?id=216387
+        <rdar://problem/66286777>
+
+        Reviewed by Eric Carlson.
+
+        * page/RuntimeEnabledFeatures.h:
+        (WebCore::RuntimeEnabledFeatures::setDisableMediaExperiencePIDInheritance):
+        (WebCore::RuntimeEnabledFeatures::disableMediaExperiencePIDInheritance const):
+        * page/Settings.yaml:
+        * platform/audio/ios/MediaSessionHelperIOS.mm:
+        (MediaSessionHelperiOS::providePresentingApplicationPID):
+
 2020-09-11  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/page/RuntimeEnabledFeatures.h

@@ -290 +290 @@
 #endif
 
+#if HAVE(CELESTIAL)
+    void setDisableMediaExperiencePIDInheritance(bool isDisabled) { m_disableMediaExperiencePIDInheritance = isDisabled; }
+    bool disableMediaExperiencePIDInheritance() const { return m_disableMediaExperiencePIDInheritance; }
+#endif
+
 private:
     // Never instantiate.
@@ -431 +436 @@
 #endif
 
+#if HAVE(CELESTIAL)
+    bool m_disableMediaExperiencePIDInheritance { false };
+#endif
+
     friend class WTF::NeverDestroyed<RuntimeEnabledFeatures>;
 };

trunk/Source/WebCore/page/Settings.yaml

@@ -1116 +1116 @@
 scriptMarkupEnabled:
   initial: true
-

trunk/Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm

@@ -31 +31 @@
 #import "Logging.h"
 #import "MediaPlaybackTargetCocoa.h"
+#import "RuntimeEnabledFeatures.h"
 #import "WebCoreThreadRun.h"
 #import <AVFoundation/AVAudioSession.h>
@@ -184 +185 @@
         return;
     m_havePresentedApplicationPID = true;
+
+    if (RuntimeEnabledFeatures::sharedFeatures().disableMediaExperiencePIDInheritance())
+        return;
 
     if (!canLoadAVSystemController_PIDToInheritApplicationStateFrom())

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-09-11  Jer Noble  <jer.noble@apple.com>
+
+        [iOS] Add Experimental setting to disable calling PID Inheritance API.
+        https://bugs.webkit.org/show_bug.cgi?id=216387
+        <rdar://problem/66286777>
+
+        Reviewed by Eric Carlson.
+
+        * Shared/WebPreferences.yaml:
+
 2020-09-11  Kate Cheney  <katherine_cheney@apple.com>
 

trunk/Source/WebKit/Shared/WebPreferences.yaml

@@ -2158 +2158 @@
   category: experimental
   condition: ENABLE(CORE_IMAGE_ACCELERATED_FILTER_RENDER)
+
+DisableMediaExperiencePIDInheritance:
+  type: bool
+  defaultValue: false
+  webcoreBinding: RuntimeEnabledFeatures
+  humanReadableName: "Disable Media Experience PID Inheritance"
+  humanReadableDescription: "Disable Media Experience PID Inheritance"
+  category: experimental
+  condition: HAVE(CELESTIAL)