Changeset 267011 in webkit


Ignore:
Timestamp:
Sep 14, 2020 8:28:02 AM (4 years ago)
Author:
weinig@apple.com
Message:

[WebIDL] Split DOM Parsing related functions out of Element and ShadowRoot and into their own IDL files to match specs
​https://bugs.webkit.org/show_bug.cgi?id=216461

Reviewed by Darin Adler.

Source/WebCore:

No behavior change, just cleaning up which IDL files DOM Parsing related operations
live to match specs.

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Element.idl:
  • dom/ElementDOMParsing.idl: Added.
  • dom/InnerHTML.idl: Added.
  • dom/ShadowRoot.idl:

LayoutTests:

  • js/dom/dom-static-property-for-in-iteration-expected.txt:
  • platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:
  • platform/ios-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
  • platform/mac-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
  • platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:

Update for change in iteration order due to use of partial interfaces.

Location:
trunk
Files:
2 added
14 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r267010 r267011  
     12020-09-14  Sam Weinig  <weinig@apple.com>
     2
     3        [WebIDL] Split DOM Parsing related functions out of Element and ShadowRoot and into their own IDL files to match specs
     4        https://bugs.webkit.org/show_bug.cgi?id=216461
     5
     6        Reviewed by Darin Adler.
     7
     8        * js/dom/dom-static-property-for-in-iteration-expected.txt:
     9        * platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:
     10        * platform/ios-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
     11        * platform/mac-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
     12        * platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:
     13        Update for change in iteration order due to use of partial interfaces.
     14
    1152020-09-14  Philippe Normand  <pnormand@igalia.com>
    216

  • trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt

    r266801 r267011  
    152152PASS a["clientWidth"] is 0
    153153PASS a["clientHeight"] is 0
    154 PASS a["innerHTML"] is nerget
    155 PASS a["outerHTML"] is <a id="foo" href="bar">nerget</a>
    156154PASS a["oncopy"] is null
    157155PASS a["oncut"] is null
    158156PASS a["onpaste"] is null
     157PASS a["outerHTML"] is <a id="foo" href="bar">nerget</a>
     158PASS a["innerHTML"] is nerget
    159159PASS a["previousElementSibling"] is [object HTMLDivElement]
    160160PASS a["nextElementSibling"] is [object HTMLScriptElement]

  • trunk/LayoutTests/platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt

    r266801 r267011  
    155155PASS a["clientWidth"] is 0
    156156PASS a["clientHeight"] is 0
    157 PASS a["innerHTML"] is nerget
    158 PASS a["outerHTML"] is <a id="foo" href="bar">nerget</a>
    159157PASS a["oncopy"] is null
    160158PASS a["oncut"] is null
    161159PASS a["onpaste"] is null
     160PASS a["outerHTML"] is <a id="foo" href="bar">nerget</a>
     161PASS a["innerHTML"] is nerget
    162162PASS a["previousElementSibling"] is [object HTMLDivElement]
    163163PASS a["nextElementSibling"] is [object HTMLScriptElement]

  • trunk/LayoutTests/platform/ios-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt

    r266801 r267011  
    142142PASS a["clientWidth"] is 0
    143143PASS a["clientHeight"] is 0
    144 PASS a["innerHTML"] is nerget
    145 PASS a["outerHTML"] is <a id="foo" href="bar">nerget</a>
    146144PASS a["oncopy"] is null
    147145PASS a["oncut"] is null
    148146PASS a["onpaste"] is null
     147PASS a["outerHTML"] is <a id="foo" href="bar">nerget</a>
     148PASS a["innerHTML"] is nerget
    149149PASS a["previousElementSibling"] is [object HTMLDivElement]
    150150PASS a["nextElementSibling"] is [object HTMLScriptElement]

  • trunk/LayoutTests/platform/mac-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt

    r266801 r267011  
    156156PASS a["clientWidth"] is 0
    157157PASS a["clientHeight"] is 0
    158 PASS a["innerHTML"] is nerget
    159 PASS a["outerHTML"] is <a id="foo" href="bar">nerget</a>
    160158PASS a["oncopy"] is null
    161159PASS a["oncut"] is null
    162160PASS a["onpaste"] is null
     161PASS a["outerHTML"] is <a id="foo" href="bar">nerget</a>
     162PASS a["innerHTML"] is nerget
    163163PASS a["previousElementSibling"] is [object HTMLDivElement]
    164164PASS a["nextElementSibling"] is [object HTMLScriptElement]

  • trunk/LayoutTests/platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt

    r266801 r267011  
    154154PASS a["clientWidth"] is 0
    155155PASS a["clientHeight"] is 0
    156 PASS a["innerHTML"] is nerget
    157 PASS a["outerHTML"] is <a id="foo" href="bar">nerget</a>
    158156PASS a["oncopy"] is null
    159157PASS a["oncut"] is null
    160158PASS a["onpaste"] is null
     159PASS a["outerHTML"] is <a id="foo" href="bar">nerget</a>
     160PASS a["innerHTML"] is nerget
    161161PASS a["previousElementSibling"] is [object HTMLDivElement]
    162162PASS a["nextElementSibling"] is [object HTMLScriptElement]

  • trunk/Source/WebCore/CMakeLists.txt

    r266926 r267011  
    794794    dom/DragEvent.idl
    795795    dom/Element.idl
     796    dom/ElementDOMParsing.idl
    796797    dom/ErrorEvent.idl
    797798    dom/Event.idl
    … …  
    806807    dom/IdleRequestCallback.idl
    807808    dom/IdleRequestOptions.idl
     809    dom/InnerHTML.idl
    808810    dom/InputEvent.idl
    809811    dom/KeyboardEvent.idl

  • trunk/Source/WebCore/ChangeLog

    r267009 r267011  
     12020-09-14  Sam Weinig  <weinig@apple.com>
     2
     3        [WebIDL] Split DOM Parsing related functions out of Element and ShadowRoot and into their own IDL files to match specs
     4        https://bugs.webkit.org/show_bug.cgi?id=216461
     5
     6        Reviewed by Darin Adler.
     7
     8        No behavior change, just cleaning up which IDL files DOM Parsing related operations
     9        live to match specs.
     10
     11        * CMakeLists.txt:
     12        * DerivedSources-input.xcfilelist:
     13        * DerivedSources-output.xcfilelist:
     14        * DerivedSources.make:
     15        * WebCore.xcodeproj/project.pbxproj:
     16        * dom/Element.idl:
     17        * dom/ElementDOMParsing.idl: Added.
     18        * dom/InnerHTML.idl: Added.
     19        * dom/ShadowRoot.idl:
     20
    1212020-09-14  Chris Lord  <clord@igalia.com>
    222

  • trunk/Source/WebCore/DerivedSources-input.xcfilelist

    r266926 r267011  
    712712$(PROJECT_DIR)/dom/DragEvent.idl
    713713$(PROJECT_DIR)/dom/Element.idl
     714$(PROJECT_DIR)/dom/ElementDOMParsing.idl
    714715$(PROJECT_DIR)/dom/ErrorEvent.idl
    715716$(PROJECT_DIR)/dom/Event.idl
    … …  
    727728$(PROJECT_DIR)/dom/IdleRequestCallback.idl
    728729$(PROJECT_DIR)/dom/IdleRequestOptions.idl
     730$(PROJECT_DIR)/dom/InnerHTML.idl
    729731$(PROJECT_DIR)/dom/InputEvent.idl
    730732$(PROJECT_DIR)/dom/KeyboardEvent.idl

  • trunk/Source/WebCore/DerivedSources-output.xcfilelist

    r266926 r267011  
    621621$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSElementCSSInlineStyle.cpp
    622622$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSElementCSSInlineStyle.h
     623$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSElementDOMParsing.cpp
     624$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSElementDOMParsing.h
    623625$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSEndingType.cpp
    624626$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSEndingType.h
    … …  
    10451047$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSImageSmoothingQuality.cpp
    10461048$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSImageSmoothingQuality.h
     1049$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSInnerHTML.cpp
     1050$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSInnerHTML.h
    10471051$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSInputEvent.cpp
    10481052$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSInputEvent.h

  • trunk/Source/WebCore/DerivedSources.make

    r266926 r267011  
    744744    $(WebCore)/dom/DragEvent.idl \
    745745    $(WebCore)/dom/Element.idl \
     746    $(WebCore)/dom/ElementDOMParsing.idl \
    746747    $(WebCore)/dom/ErrorEvent.idl \
    747748    $(WebCore)/dom/Event.idl \
    … …  
    757758    $(WebCore)/dom/IdleRequestCallback.idl \
    758759    $(WebCore)/dom/IdleRequestOptions.idl \
     760    $(WebCore)/dom/InnerHTML.idl \
    759761    $(WebCore)/dom/InputEvent.idl \
    760762    $(WebCore)/dom/KeyboardEvent.idl \

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r267003 r267011  
    1037310373                7CD70C4324A28BEC00E61040 /* SVGStringList.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = SVGStringList.cpp; sourceTree = "<group>"; };
    1037410374                7CD70C4624A28CD700E61040 /* SVGTransformList.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = SVGTransformList.cpp; sourceTree = "<group>"; };
     10375                7CDA7912250E88F0007D1B36 /* InnerHTML.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = InnerHTML.idl; sourceTree = "<group>"; };
     10376                7CDA7919250E8C92007D1B36 /* ElementDOMParsing.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = ElementDOMParsing.idl; sourceTree = "<group>"; };
    1037510377                7CDE73961F9BD59500390312 /* Settings.yaml */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = Settings.yaml; sourceTree = "<group>"; };
    1037610378                7CDE8EBC1F193BC500168FE7 /* CSSStyleDeclaration.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CSSStyleDeclaration.cpp; sourceTree = "<group>"; };
    … …  
    2929629298                                B5B7A16F17C1080600E4AA0A /* ElementData.cpp */,
    2929729299                                B5B7A16E17C1048000E4AA0A /* ElementData.h */,
     29300                                7CDA7919250E8C92007D1B36 /* ElementDOMParsing.idl */,
    2929829301                                2D2BEB2F2234A334005544CA /* ElementIdentifier.h */,
    2929929302                                E4AE7C1517D1BB950009FB31 /* ElementIterator.h */,
    … …  
    2937729380                                AA4C3A740B2B1679002334A2 /* InlineStyleSheetOwner.cpp */,
    2937829381                                AA4C3A750B2B1679002334A2 /* InlineStyleSheetOwner.h */,
     29382                                7CDA7912250E88F0007D1B36 /* InnerHTML.idl */,
    2937929383                                2EB767551DA19B99003E23B5 /* InputEvent.cpp */,
    2938029384                                2EB767541DA19B67003E23B5 /* InputEvent.h */,

  • trunk/Source/WebCore/dom/Element.idl

    r266662 r267011  
    8989    readonly attribute double clientHeight; // FIXME: Should be of type long.
    9090
    91     // Extensions to Element from DOM Parsing and Serialization specification.
    92     // https://w3c.github.io/DOM-Parsing/#extensions-to-the-element-interface
    93     [CEReactions] attribute [LegacyNullToEmptyString] DOMString innerHTML;
    94     [CEReactions] attribute [LegacyNullToEmptyString] DOMString outerHTML;
    95     [CEReactions, MayThrowException] undefined insertAdjacentHTML(DOMString position, DOMString text);
    96 
    9791    // Extensions from Full Screen API (https://fullscreen.spec.whatwg.org/#api).
    9892    // FIXME: Should we add unprefixed versions?
    … …  
    157151Element includes ParentNode;
    158152Element includes Slotable;
     153Element includes InnerHTML;

  • trunk/Source/WebCore/dom/ShadowRoot.idl

    r266662 r267011  
    3030    readonly attribute ShadowRootMode mode;
    3131    readonly attribute Element host;
    32 
    33     // FIXME: Seems to have been dropped from the Shadow DOM API.
    34     [CEReactions] attribute [LegacyNullToEmptyString] DOMString innerHTML;
     32    // FIXME: Implement 'onslotchange'.
     33    // attribute EventHandler onslotchange;
    3534};
    3635
    3736ShadowRoot includes DocumentOrShadowRoot;
     37ShadowRoot includes InnerHTML;
Note: See TracChangeset for help on using the changeset viewer.