Changeset 267028 in webkit

Timestamp:

Sep 14, 2020 12:30:11 PM (4 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION(r266885): dyld: Symbol not found: ZN9Inspector17BackendDispatcher12sendResponseElON3WTF6RefPtrINS1_8JSONImpl6ObjectENS1_13DumbPtrTraitsIS4_EEEEb
​https://bugs.webkit.org/show_bug.cgi?id=216486

Reviewed by Joseph Pecoraro.

• inspector/InspectorBackendDispatcher.h:
• inspector/InspectorBackendDispatcher.cpp:

(Inspector::BackendDispatcher::sendResponse):
Add back overloads removed in r266885 so that the symbols exist.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/InspectorBackendDispatcher.cpp (modified) (1 diff)
• inspector/InspectorBackendDispatcher.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-09-14  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION(r266885): dyld: Symbol not found: __ZN9Inspector17BackendDispatcher12sendResponseElON3WTF6RefPtrINS1_8JSONImpl6ObjectENS1_13DumbPtrTraitsIS4_EEEEb
+        https://bugs.webkit.org/show_bug.cgi?id=216486
+
+        Reviewed by Joseph Pecoraro.
+
+        * inspector/InspectorBackendDispatcher.h:
+        * inspector/InspectorBackendDispatcher.cpp:
+        (Inspector::BackendDispatcher::sendResponse):
+        Add back overloads removed in r266885 so that the symbols exist.
+
 2020-09-14  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp

@@ -189 +189 @@
 
 // FIXME: remove this function when legacy InspectorObject symbols are no longer needed <http://webkit.org/b/179847>.
+void BackendDispatcher::sendResponse(long requestId, RefPtr<JSON::Object>&& result)
+{
+    ASSERT(result);
+    sendResponse(requestId, result.releaseNonNull(), false);
+}
+
+// FIXME: remove this function when legacy InspectorObject symbols are no longer needed <http://webkit.org/b/179847>.
+void BackendDispatcher::sendResponse(long requestId, RefPtr<JSON::Object>&& result, bool)
+{
+    ASSERT(result);
+    sendResponse(requestId, result.releaseNonNull(), false);
+}
+
+// FIXME: remove this function when legacy InspectorObject symbols are no longer needed <http://webkit.org/b/179847>.
 void BackendDispatcher::sendResponse(long requestId, Ref<JSON::Object>&& result)
 {

trunk/Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h

@@ -90 +90 @@
     // When <http://webkit.org/b/179847> is fixed or this class is renamed for the JSON::Object case,
     // then this alternate method with a dummy parameter can be removed in favor of the one without it.
+    void sendResponse(long requestId, RefPtr<JSON::Object>&& result);
+    void sendResponse(long requestId, RefPtr<JSON::Object>&& result, bool unused);
+    void sendResponse(long requestId, Ref<JSON::Object>&& result);
     void sendResponse(long requestId, Ref<JSON::Object>&& result, bool unused);
-    void sendResponse(long requestId, Ref<JSON::Object>&& result);
     void sendPendingErrors();