Changeset 267095 in webkit
- Timestamp:
- Sep 15, 2020 12:43:40 PM (4 years ago)
- Location:
- trunk
- Files:
-
- 18 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r267094 r267095 1 2020-09-15 Sam Weinig <weinig@apple.com> 2 3 Remove runtime setting for enabling/disabling custom elements 4 https://bugs.webkit.org/show_bug.cgi?id=216518 5 6 Reviewed by Tim Horton. 7 8 Remove runtime setting for enabling/disabling custom elements. There is no 9 reason one need to disable it now, and it has been on by default for 10 a long enough time. 11 12 * dom/CustomElementRegistry.idl: 13 * dom/Document.cpp: 14 (WebCore::createUpgradeCandidateElement): 15 * page/DOMWindow.idl: 16 * page/Settings.yaml: 17 1 18 2020-09-15 Chris Dumez <cdumez@apple.com> 2 19 -
trunk/Source/WebCore/dom/CustomElementRegistry.idl
r266360 r267095 25 25 26 26 [ 27 EnabledBySetting=CustomElements,28 27 GenerateIsReachable=ImplScriptExecutionContext, 29 28 JSGenerateToNativeObject, -
trunk/Source/WebCore/dom/Document.cpp
r266991 r267095 951 951 static ALWAYS_INLINE Ref<HTMLElement> createUpgradeCandidateElement(Document& document, const QualifiedName& name) 952 952 { 953 if (!document.settings().customElementsEnabled() 954 || Document::validateCustomElementName(name.localName()) != CustomElementNameValidationStatus::Valid) 953 if (Document::validateCustomElementName(name.localName()) != CustomElementNameValidationStatus::Valid) 955 954 return HTMLUnknownElement::create(name, document); 956 955 -
trunk/Source/WebCore/page/DOMWindow.idl
r266706 r267095 58 58 [DoNotCheckSecurity, PutForwards=href, LegacyUnforgeable] readonly attribute Location location; 59 59 readonly attribute History history; 60 [ EnabledBySetting=CustomElements,ImplementedAs=ensureCustomElementRegistry] readonly attribute CustomElementRegistry customElements;60 [ImplementedAs=ensureCustomElementRegistry] readonly attribute CustomElementRegistry customElements; 61 61 [Replaceable] readonly attribute BarProp locationbar; 62 62 [Replaceable] readonly attribute BarProp menubar; -
trunk/Source/WebCore/page/Settings.yaml
r266931 r267095 1003 1003 initial: true 1004 1004 1005 customElementsEnabled:1006 initial: true1007 1008 1005 dataTransferItemsEnabled: 1009 1006 initial: false -
trunk/Source/WebKit/ChangeLog
r267092 r267095 1 2020-09-15 Sam Weinig <weinig@apple.com> 2 3 Remove runtime setting for enabling/disabling custom elements 4 https://bugs.webkit.org/show_bug.cgi?id=216518 5 6 Reviewed by Tim Horton. 7 8 Remove runtime setting for enabling/disabling custom elements. There is no 9 reason one need to disable it now, and it has been on by default for 10 a long enough time. 11 12 * Shared/WebPreferences.yaml: 13 1 14 2020-09-15 Simon Fraser <simon.fraser@apple.com> 2 15 -
trunk/Source/WebKit/Shared/WebPreferences.yaml
r267069 r267095 812 812 813 813 AnimatedImageAsyncDecodingEnabled: 814 type: bool815 defaultValue: true816 817 CustomElementsEnabled:818 814 type: bool 819 815 defaultValue: true -
trunk/Source/WebKitLegacy/mac/ChangeLog
r267069 r267095 1 2020-09-15 Sam Weinig <weinig@apple.com> 2 3 Remove runtime setting for enabling/disabling custom elements 4 https://bugs.webkit.org/show_bug.cgi?id=216518 5 6 Reviewed by Tim Horton. 7 8 Remove runtime setting for enabling/disabling custom elements. There is no 9 reason one need to disable it now, and it has been on by default for 10 a long enough time. 11 12 * WebView/WebPreferenceKeysPrivate.h: 13 * WebView/WebPreferences.mm: 14 (+[WebPreferences initialize]): 15 (-[WebPreferences setCustomElementsEnabled:]): 16 (-[WebPreferences customElementsEnabled]): 17 * WebView/WebPreferencesPrivate.h: 18 1 19 2020-09-14 Sam Weinig <weinig@apple.com> 2 20 -
trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
r267069 r267095 178 178 #define WebKitServiceControlsEnabledPreferenceKey @"WebKitServiceControlsEnabled" 179 179 #define WebKitMediaKeysStorageDirectoryKey @"WebKitMediaKeysStorageDirectory" 180 #define WebKitCustomElementsEnabledPreferenceKey @"WebKitCustomElementsEnabled"181 180 #define WebKitDataTransferItemsEnabledPreferenceKey @"WebKitDataTransferItemsEnabled" 182 181 #define WebKitCustomPasteboardDataEnabledPreferenceKey @"WebKitCustomPasteboardDataEnabled" … … 296 295 #define WebKitShadowDOMEnabledPreferenceKey @"WebKitShadowDOMEnabled" 297 296 #define WebKitHixie76WebSocketProtocolEnabledKey @"WebKitHixie76WebSocketProtocolEnabled" 297 #define WebKitCustomElementsEnabledPreferenceKey @"WebKitCustomElementsEnabled" -
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
r267069 r267095 632 632 @YES, WebKitMediaCaptureRequiresSecureConnectionPreferenceKey, 633 633 #endif 634 @YES, WebKitCustomElementsEnabledPreferenceKey,635 634 @YES, WebKitDataTransferItemsEnabledPreferenceKey, 636 635 @NO, WebKitCustomPasteboardDataEnabledPreferenceKey, … … 3049 3048 } 3050 3049 3051 - (BOOL)customElementsEnabled3052 {3053 return [self _boolValueForKey:WebKitCustomElementsEnabledPreferenceKey];3054 }3055 3056 - (void)setCustomElementsEnabled:(BOOL)flag3057 {3058 [self _setBoolValue:flag forKey:WebKitCustomElementsEnabledPreferenceKey];3059 }3060 3061 3050 - (BOOL)dataTransferItemsEnabled 3062 3051 { … … 3724 3713 } 3725 3714 3715 - (void)setCustomElementsEnabled:(BOOL)flag 3716 { 3717 } 3718 3719 - (BOOL)customElementsEnabled 3720 { 3721 return YES; 3722 } 3723 3726 3724 - (void)setVideoPluginProxyEnabled:(BOOL)flag 3727 3725 { -
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
r267069 r267095 537 537 - (void)setMediaCaptureRequiresSecureConnection:(BOOL)flag; 538 538 - (BOOL)mediaCaptureRequiresSecureConnection; 539 540 - (void)setCustomElementsEnabled:(BOOL)flag;541 - (BOOL)customElementsEnabled;542 539 543 540 - (void)setDataTransferItemsEnabled:(BOOL)flag; … … 706 703 - (BOOL)shadowDOMEnabled; 707 704 705 - (void)setCustomElementsEnabled:(BOOL)flag; 706 - (BOOL)customElementsEnabled; 707 708 708 - (void)setVideoPluginProxyEnabled:(BOOL)flag; 709 709 - (BOOL)isVideoPluginProxyEnabled; -
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
r267069 r267095 3326 3326 RuntimeEnabledFeatures::sharedFeatures().setHighlightAPIEnabled([preferences highlightAPIEnabled]); 3327 3327 3328 settings.setCustomElementsEnabled([preferences customElementsEnabled]);3329 3328 settings.setDataTransferItemsEnabled([preferences dataTransferItemsEnabled]); 3330 3329 RuntimeEnabledFeatures::sharedFeatures().setCustomPasteboardDataEnabled([preferences customPasteboardDataEnabled]); -
trunk/Source/WebKitLegacy/win/ChangeLog
r267069 r267095 1 2020-09-15 Sam Weinig <weinig@apple.com> 2 3 Remove runtime setting for enabling/disabling custom elements 4 https://bugs.webkit.org/show_bug.cgi?id=216518 5 6 Reviewed by Tim Horton. 7 8 Remove runtime setting for enabling/disabling custom elements. There is no 9 reason one need to disable it now, and it has been on by default for 10 a long enough time. 11 12 * WebPreferences.cpp: 13 (WebPreferences::customElementsEnabled): 14 (WebPreferences::setCustomElementsEnabled): 15 * WebView.cpp: 16 (WebView::notifyPreferencesChanged): 17 1 18 2020-09-14 Sam Weinig <weinig@apple.com> 2 19 -
trunk/Source/WebKitLegacy/win/WebPreferences.cpp
r267069 r267095 2078 2078 if (!enabled) 2079 2079 return E_POINTER; 2080 *enabled = boolValueForKey(WebKitCustomElementsEnabledPreferenceKey); 2081 return S_OK; 2082 } 2083 2084 HRESULT WebPreferences::setCustomElementsEnabled(BOOL enabled) 2085 { 2086 setBoolValue(WebKitCustomElementsEnabledPreferenceKey, enabled); 2080 *enabled = true; 2081 return S_OK; 2082 } 2083 2084 HRESULT WebPreferences::setCustomElementsEnabled(BOOL) 2085 { 2087 2086 return S_OK; 2088 2087 } -
trunk/Source/WebKitLegacy/win/WebView.cpp
r267069 r267095 5235 5235 RuntimeEnabledFeatures::sharedFeatures().setFetchAPIEnabled(!!enabled); 5236 5236 5237 hr = prefsPrivate->customElementsEnabled(&enabled);5238 if (FAILED(hr))5239 return hr;5240 settings.setCustomElementsEnabled(!!enabled);5241 5242 5237 hr = prefsPrivate->menuItemElementEnabled(&enabled); 5243 5238 if (FAILED(hr)) -
trunk/Tools/ChangeLog
r267093 r267095 1 2020-09-15 Sam Weinig <weinig@apple.com> 2 3 Remove runtime setting for enabling/disabling custom elements 4 https://bugs.webkit.org/show_bug.cgi?id=216518 5 6 Reviewed by Tim Horton. 7 8 Remove runtime setting for enabling/disabling custom elements. There is no 9 reason one need to disable it now, and it has been on by default for 10 a long enough time. 11 12 * DumpRenderTree/mac/DumpRenderTree.mm: 13 (resetWebPreferencesToConsistentValues): 14 * DumpRenderTree/win/DumpRenderTree.cpp: 15 (resetWebPreferencesToConsistentValues): 16 1 17 2020-09-15 Jonathan Bedard <jbedard@apple.com> 2 18 -
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
r267069 r267095 936 936 [preferences setSourceBufferChangeTypeEnabled:YES]; 937 937 938 [preferences setCustomElementsEnabled:YES];939 940 938 [preferences setDataTransferItemsEnabled:YES]; 941 939 [preferences setCustomPasteboardDataEnabled:YES]; -
trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp
r267069 r267095 899 899 900 900 prefsPrivate->setFetchAPIEnabled(TRUE); 901 prefsPrivate->setCustomElementsEnabled(TRUE);902 901 prefsPrivate->setResourceTimingEnabled(TRUE); 903 902 prefsPrivate->setUserTimingEnabled(TRUE);
Note: See TracChangeset
for help on using the changeset viewer.