Changeset 267284 in webkit

Timestamp:

Sep 18, 2020 3:25:44 PM (4 years ago)

Author:

sihui_liu@apple.com

Message:

REGRESSION (r266634): fast/selectors/text-field-selection-stroke-color.html and fast/selectors/text-field-selection-window-inactive-stroke-color.html are flaky failures with pixel noise
​https://bugs.webkit.org/show_bug.cgi?id=216394
<rdar://problem/68679551>

Reviewed by Tim Horton.

Source/WebKit:

In WebKitTestRunner, we reset the states and load about:blank page between tests. The resetting may cause some
activity state changes of web page, like WindowIsActive. Before r266634, these changes will be dispatched
quickly enough (before runloop waits or when runloop exits) to web process, so web process can do rendering with
updated activity state. After r266634, dispatch of the changes may be delayed (until CATransaction commits).
Page activity state can affect scrollability (in FrameView::computeScrollability()) and scrollability can affect
tiling size (in TileController::computeTileSize()). Different tilings may cause the tiny pixel difference we see
in the test results.

To fix this, create an SPI for sending out activity state updates in next runloop cycle and adopt it in WTR.

• UIProcess/API/C/WKPage.cpp:

(WKPageDispatchActivityStateUpdateForTesting):

• UIProcess/API/C/WKPagePrivate.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dispatchActivityStateUpdateForTesting):

• UIProcess/WebPageProxy.h:

Tools:

Make sure activity state changes for window updates in resetStateToConsistentValues are dispatched in time.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Update test expectations as tests should be passing.

• platform/mac-wk2/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac-wk2/TestExpectations (modified) (1 diff)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/API/C/WKPage.cpp (modified) (1 diff)
• Source/WebKit/UIProcess/API/C/WKPagePrivate.h (modified) (1 diff)
• Source/WebKit/UIProcess/WebPageProxy.cpp (modified) (1 diff)
• Source/WebKit/UIProcess/WebPageProxy.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/WebKitTestRunner/TestController.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-09-18  Sihui Liu  <sihui_liu@apple.com>
+
+        REGRESSION (r266634): fast/selectors/text-field-selection-stroke-color.html and fast/selectors/text-field-selection-window-inactive-stroke-color.html are flaky failures with pixel noise
+        https://bugs.webkit.org/show_bug.cgi?id=216394
+        <rdar://problem/68679551>
+
+        Reviewed by Tim Horton.
+
+        Update test expectations as tests should be passing.
+
+        * platform/mac-wk2/TestExpectations:
+
 2020-09-18  Aditya Keerthi  <akeerthi@apple.com>
 

trunk/LayoutTests/platform/mac-wk2/TestExpectations

@@ -1312 +1312 @@
 http/tests/resourceLoadStatistics/exemptDomains/ [ Skip ]
 
-webkit.org/b/216394 [ Release ] fast/selectors/text-field-selection-stroke-color.html [ Pass ImageOnlyFailure ]
-webkit.org/b/216394 [ Release ] fast/selectors/selection-window-inactive-stroke-color.html [ Pass ImageOnlyFailure ]
-
 # rdar://68740987 (REGRESSION: [ BigSur wk2 ] http/tests/media/video-no-content-length-stall.html is a constant failure)
 [ BigSur+ ] http/tests/media/video-no-content-length-stall.html [ Failure ]

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-09-18  Sihui Liu  <sihui_liu@apple.com>
+
+        REGRESSION (r266634): fast/selectors/text-field-selection-stroke-color.html and fast/selectors/text-field-selection-window-inactive-stroke-color.html are flaky failures with pixel noise
+        https://bugs.webkit.org/show_bug.cgi?id=216394
+        <rdar://problem/68679551>
+
+        Reviewed by Tim Horton.
+
+        In WebKitTestRunner, we reset the states and load about:blank page between tests. The resetting may cause some
+        activity state changes of web page, like WindowIsActive. Before r266634, these changes will be dispatched
+        quickly enough (before runloop waits or when runloop exits) to web process, so web process can do rendering with
+        updated activity state. After r266634, dispatch of the changes may be delayed (until CATransaction commits). 
+        Page activity state can affect scrollability (in FrameView::computeScrollability()) and scrollability can affect
+        tiling size (in TileController::computeTileSize()). Different tilings may cause the tiny pixel difference we see
+        in the test results.
+
+        To fix this, create an SPI for sending out activity state updates in next runloop cycle and adopt it in WTR.
+
+        * UIProcess/API/C/WKPage.cpp:
+        (WKPageDispatchActivityStateUpdateForTesting):
+        * UIProcess/API/C/WKPagePrivate.h:
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::dispatchActivityStateUpdateForTesting):
+        * UIProcess/WebPageProxy.h:
+
 2020-09-18  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp

@@ -3003 +3003 @@
     toImpl(page)->setMediaCaptureReportingDelay(Seconds(delay));
 }
+
+void WKPageDispatchActivityStateUpdateForTesting(WKPageRef page)
+{
+    toImpl(page)->dispatchActivityStateUpdateForTesting();
+}

trunk/Source/WebKit/UIProcess/API/C/WKPagePrivate.h

@@ -201 +201 @@
 WK_EXPORT void WKPageSetMediaCaptureReportingDelayForTesting(WKPageRef page, double delay);
 
+WK_EXPORT void WKPageDispatchActivityStateUpdateForTesting(WKPageRef page);
+
 #ifdef __cplusplus
 }

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -10312 +10312 @@
 #endif
 
+void WebPageProxy::dispatchActivityStateUpdateForTesting()
+{
+    RunLoop::current().dispatch([protectedThis = makeRef(*this)] {
+        protectedThis->dispatchActivityStateChange();
+    });
+}
+
 } // namespace WebKit
 

trunk/Source/WebKit/UIProcess/WebPageProxy.h

@@ -901 +901 @@
 #endif // PLATFORM(COCOA)
 
+    void dispatchActivityStateUpdateForTesting();
+
     void changeFontAttributes(WebCore::FontAttributeChanges&&);
     void changeFont(WebCore::FontChanges&&);

trunk/Tools/ChangeLog

@@ +1 @@
+2020-09-18  Sihui Liu  <sihui_liu@apple.com>
+
+        REGRESSION (r266634): fast/selectors/text-field-selection-stroke-color.html and fast/selectors/text-field-selection-window-inactive-stroke-color.html are flaky failures with pixel noise
+        https://bugs.webkit.org/show_bug.cgi?id=216394
+        <rdar://problem/68679551>
+
+        Reviewed by Tim Horton.
+
+        Make sure activity state changes for window updates in resetStateToConsistentValues are dispatched in time.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::resetStateToConsistentValues):
+
 2020-09-18  Aditya Keerthi  <akeerthi@apple.com>
 

trunk/Tools/WebKitTestRunner/TestController.cpp

@@ -1161 +1161 @@
     clearAppBoundSession();
     clearAdClickAttribution();
+
+    WKPageDispatchActivityStateUpdateForTesting(m_mainWebView->page());
 
     m_didReceiveServerRedirectForProvisionalNavigation = false;