Changeset 267770 in webkit

Timestamp:

Sep 29, 2020 4:31:58 PM (4 years ago)

Author:

James Darpinian

Message:

Fix EXT_color_buffer_half_float on iOS
​https://bugs.webkit.org/show_bug.cgi?id=217107

Reviewed by Kenneth Russell.

• src/libANGLE/Context.cpp:

(gl::Context::generateSupportedExtensions const):

• src/libANGLE/renderer/gl/renderergl_utils.cpp:

(rx::nativegl_gl::GenerateTextureFormatCaps):

Location:

trunk/Source/ThirdParty/ANGLE

Files:

• ChangeLog (modified) (1 diff)
• src/libANGLE/Context.cpp (modified) (1 diff)
• src/libANGLE/renderer/gl/renderergl_utils.cpp (modified) (1 diff)

trunk/Source/ThirdParty/ANGLE/ChangeLog

@@ +1 @@
+2020-09-29  James Darpinian  <jdarpinian@chromium.org>
+
+        Fix EXT_color_buffer_half_float on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=217107
+
+        Reviewed by Kenneth Russell.
+
+        * src/libANGLE/Context.cpp:
+        (gl::Context::generateSupportedExtensions const):
+        * src/libANGLE/renderer/gl/renderergl_utils.cpp:
+        (rx::nativegl_gl::GenerateTextureFormatCaps):
+
 2020-09-24  Dean Jackson  <dino@apple.com>
 

trunk/Source/ThirdParty/ANGLE/src/libANGLE/Context.cpp

@@ -3193 +3193 @@
         // that blitting is always allowed if the requested formats are exposed and have the correct
         // feature capabilities
-        if (!supportedExtensions.colorBufferFloat)
+        if (!supportedExtensions.colorBufferFloat && !mWebGLContext)
         {
             supportedExtensions.colorBufferHalfFloat = false;

trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp

@@ -289 +289 @@
 
     // Do extra renderability validation for some formats.
+    if (internalFormat == GL_R16F || internalFormat == GL_RG16F || internalFormat == GL_RGB16F)
+    {
+        // SupportRequirement can't currently express a condition of the form (version && extension)
+        // || other extensions, so do the (version && extension) part here.
+        if (functions->isAtLeastGLES(gl::Version(3, 0)) &&
+            functions->hasGLESExtension("GL_EXT_color_buffer_half_float"))
+        {
+            textureCaps.textureAttachment = true;
+            textureCaps.renderbuffer      = true;
+        }
+    }
+
     // We require GL_RGBA16F is renderable to expose EXT_color_buffer_half_float but we can't know
     // if the format is supported unless we try to create a framebuffer.