Changeset 268246 in webkit

Timestamp:

Oct 8, 2020 9:02:48 PM (4 years ago)

Author:

Chris Fleizach

Message:

AX: Website Warning page is inaccessible
​https://bugs.webkit.org/show_bug.cgi?id=217489

Reviewed by Zalan Bujtas.

If we have a safe browsing window, we need to use that instead of the content view.

• UIProcess/Cocoa/WKSafeBrowsingWarning.h:
• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::accessibilityAttributeValue):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Cocoa/WKSafeBrowsingWarning.h (modified) (1 diff)
• UIProcess/Cocoa/WebViewImpl.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-10-08  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Website Warning page is inaccessible
+        https://bugs.webkit.org/show_bug.cgi?id=217489
+
+        Reviewed by Zalan Bujtas.
+
+        If we have a safe browsing window, we need to use that instead of the content view.
+
+        * UIProcess/Cocoa/WKSafeBrowsingWarning.h:
+        * UIProcess/Cocoa/WebViewImpl.mm:
+        (WebKit::WebViewImpl::accessibilityAttributeValue):
+
 2020-10-08  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.h

@@ -62 +62 @@
 
 #if PLATFORM(MAC)
-@interface WKSafeBrowsingWarning : WKSafeBrowsingBox<NSTextViewDelegate>
+@interface WKSafeBrowsingWarning : WKSafeBrowsingBox<NSTextViewDelegate, NSAccessibilityGroup>
 #else
 @interface WKSafeBrowsingWarning : UIScrollView<UITextViewDelegate>

trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm

@@ -3732 +3732 @@
 
         id child = nil;
-        if (m_remoteAccessibilityChild)
+        if (m_safeBrowsingWarning)
+            child = m_safeBrowsingWarning.get();
+        else if (m_remoteAccessibilityChild)
             child = m_remoteAccessibilityChild.get();