Changeset 268488 in webkit


Ignore:
Timestamp:
Oct 14, 2020 2:19:02 PM (3 years ago)
Author:
Chris Dumez
Message:

REGRESSION (r267744): [ Debug WK2 ] fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html is a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=217549

Reviewed by Sam Weinig.

After r267744, Worklet.addModule() returns a promise and no longer throws exceptions.
Update the test accordingly to expect that a promise gets rejected with an out of
memory error, instead of expecting an exception to be thrown.

  • fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt:
  • fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r268487 r268488  
     12020-10-14  Chris Dumez  <cdumez@apple.com>
     2
     3        REGRESSION (r267744): [ Debug WK2 ] fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html is a constant timeout
     4        https://bugs.webkit.org/show_bug.cgi?id=217549
     5
     6        Reviewed by Sam Weinig.
     7
     8        After r267744, Worklet.addModule() returns a promise and no longer throws exceptions.
     9        Update the test accordingly to expect that a promise gets rejected with an out of
     10        memory error, instead of expecting an exception to be thrown.
     11
     12        * fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt:
     13        * fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js:
     14
    1152020-10-14  Megan Gardner  <megan_gardner@apple.com>
    216
  • trunk/LayoutTests/TestExpectations

    r268403 r268488  
    45204520webkit.org/b/217054 fast/layoutformattingcontext/horizontal-sizing-with-trailing-letter-spacing.html [ Skip ]
    45214521
    4522 webkit.org/b/217618 [ Debug ] fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html [ Pass Timeout ]
  • trunk/LayoutTests/fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt

    r266447 r268488  
    1 
     1PASS: threw a RangeError: Out of memory exception
  • trunk/LayoutTests/fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js

    r266447 r268488  
    1717    }
    1818
     19    async function runTest() {
     20        let promises = []
     21        try {
     22            for (let i = 0; i < 5000; i++)
     23                await CSS.paintWorklet.addModule('');
     24        } catch (e) {
     25            if (e != "RangeError: Out of memory")
     26                document.write("FAIL: expect: 'RangeError: Out of memory', actual: '" + e + "'");
     27            else
     28                document.write("PASS: threw a RangeError: Out of memory exception");
     29        }
     30    }
     31
    1932    var exception;
    2033    useAllMemory();
    21     try {
    22         for (let i = 0; i < 5000; i++) {
    23             CSS.paintWorklet.addModule('');
    24         }
    25     } catch (e) {
    26         exception = e;
    27     }
    28 
    29     if (exception != "RangeError: Out of memory")
    30         throw "FAIL: expect: 'RangeError: Out of memory', actual: '" + exception + "'";
     34    runTest();
    3135}
Note: See TracChangeset for help on using the changeset viewer.