Changeset 268507 in webkit

Timestamp:

Oct 14, 2020 8:24:20 PM (4 years ago)

Author:

Brent Fulgham

Message:

[iOS] Allow additional sysctl reads needed by image decoding
​https://bugs.webkit.org/show_bug.cgi?id=217733
<rdar://problem/68649171>

Reviewed by Per Arne Vollan.

Telemetry on iOS 14 shows that we are hitting some sandbox violations during image decoding. We should
grant access to hw.byteorder, hw.cachelinesize_compat, and hw.vectorunit. We should silence warnings
about hw.cpufrequency_compat since it is not needed in web-facing use cases.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (modified) (3 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-10-14  Brent Fulgham  <bfulgham@apple.com>
+
+        [iOS] Allow additional sysctl reads needed by image decoding
+        https://bugs.webkit.org/show_bug.cgi?id=217733
+        <rdar://problem/68649171>
+
+        Reviewed by Per Arne Vollan.
+
+        Telemetry on iOS 14 shows that we are hitting some sandbox violations during image decoding. We should
+        grant access to hw.byteorder, hw.cachelinesize_compat, and hw.vectorunit. We should silence warnings
+        about hw.cpufrequency_compat since it is not needed in web-facing use cases.
+
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
 2020-10-14  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb

@@ -643 +643 @@
 
 (deny sysctl-read (with no-report)
-      (sysctl-name "sysctl.proc_native"))
+      (sysctl-name
+          "hw.cpufrequency_compat"
+          "sysctl.proc_native"))
 
 (with-filter (system-attribute apple-internal)
@@ -841 +843 @@
         "hw.activecpu" ;; Needed by JSC engine.
         "hw.availcpu"
+        "hw.byteorder"
         "hw.cachelinesize"
+        "hw.cachelinesize_compat"
         "hw.cpufamily" ;; <rdar://problem/58416475>
         "hw.cputype"
@@ -855 +859 @@
         "hw.physicalcpu_max"
         "hw.product"
+        "hw.vectorunit"
         "kern.bootargs"
         "kern.hostname"