Changeset 268570 in webkit
- Timestamp:
- Oct 15, 2020 6:45:03 PM (4 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r268569 r268570 1 2020-10-15 David Kilzer <ddkilzer@apple.com> 2 3 v2: WebKit::XPCServiceEventHandler block should call exit() on the main thread 4 <https://webkit.org/b/217773> 5 <rdar://problem/70275659> 6 7 Reviewed by Geoff Garen. 8 9 * Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm: 10 (WebKit::XPCServiceEventHandler): 11 - Use NSRunLoop instead of libdispatch to run code on the main 12 thread since libdispatch can randomly pick a new main thread when 13 exit() is called on the original main thread. 14 1 15 2020-10-15 Tim Horton <timothy_horton@apple.com> 2 16 -
trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm
r267206 r268570 51 51 RELEASE_LOG_FAULT(IPC, "Exiting: Received XPC event type: %s", event == XPC_ERROR_CONNECTION_INVALID ? "XPC_ERROR_CONNECTION_INVALID" : "XPC_ERROR_TERMINATION_IMMINENT"); 52 52 // FIXME: Handle this case more gracefully. 53 dispatch_sync(dispatch_get_main_queue(),^{53 [[NSRunLoop mainRunLoop] performBlock:^{ 54 54 exit(EXIT_FAILURE); 55 } );55 }]; 56 56 } 57 57 } else { … … 78 78 if (!initializerFunctionPtr) { 79 79 RELEASE_LOG_FAULT(IPC, "Exiting: Unable to find entry point in WebKit.framework with name: %s", [(__bridge NSString *)entryPointFunctionName UTF8String]); 80 dispatch_sync(dispatch_get_main_queue(),^{80 [[NSRunLoop mainRunLoop] performBlock:^{ 81 81 exit(EXIT_FAILURE); 82 } );82 }]; 83 83 } 84 84
Note: See TracChangeset
for help on using the changeset viewer.