Changeset 268590 in webkit


Ignore:
Timestamp:
Oct 16, 2020 8:22:48 AM (3 years ago)
Author:
commit-queue@webkit.org
Message:

[GStreamer] Remove unused ElementType values from the registry scanner
https://bugs.webkit.org/show_bug.cgi?id=217824

Patch by Philippe Normand <pnormand@igalia.com> on 2020-10-16
Reviewed by Xabier Rodriguez-Calvar.

r268576 introduced new values in the ElementType enum but they were unused and introduced
inconsistency in in fillMimeTypeSetFromCapsMapping(). If this function needs to be used for
encoding configurations it will need to be refactored but that's not a scenario I foresee,
so for now, remove unused enum values.

  • platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:

(WebCore::GStreamerRegistryScanner::fillMimeTypeSetFromCapsMapping):

  • platform/graphics/gstreamer/GStreamerRegistryScanner.h:
Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r268587 r268590  
     12020-10-16  Philippe Normand  <pnormand@igalia.com>
     2
     3        [GStreamer] Remove unused ElementType values from the registry scanner
     4        https://bugs.webkit.org/show_bug.cgi?id=217824
     5
     6        Reviewed by Xabier Rodriguez-Calvar.
     7
     8        r268576 introduced new values in the ElementType enum but they were unused and introduced
     9        inconsistency in in fillMimeTypeSetFromCapsMapping(). If this function needs to be used for
     10        encoding configurations it will need to be refactored but that's not a scenario I foresee,
     11        so for now, remove unused enum values.
     12
     13        * platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
     14        (WebCore::GStreamerRegistryScanner::fillMimeTypeSetFromCapsMapping):
     15        * platform/graphics/gstreamer/GStreamerRegistryScanner.h:
     16
    1172020-10-16  Michael Catanzaro  <mcatanzaro@gnome.org>
    218
  • trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp

    r268586 r268590  
    182182            factories = m_videoDecoderFactories;
    183183            break;
    184         case Muxer:
    185         case AudioEncoder:
    186         case VideoEncoder:
    187             // This method is currently used only for Decoders and Demuxers.
    188             ASSERT_NOT_REACHED();
    189             return;
    190184        }
    191185
  • trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h

    r268576 r268590  
    7373        AudioDecoder = 0,
    7474        VideoDecoder,
    75         Demuxer,
    76         AudioEncoder,
    77         VideoEncoder,
    78         Muxer
     75        Demuxer
    7976    };
     77
    8078    struct GstCapsWebKitMapping {
    8179        ElementType elementType;
Note: See TracChangeset for help on using the changeset viewer.